Skip to content

Add an example for FromIterator::from_iter - #23816

Merged
bors merged 1 commit into
rust-lang:masterfrom
frewsxcv:fromiterator-example
Mar 29, 2015
Merged

Add an example for FromIterator::from_iter#23816
bors merged 1 commit into
rust-lang:masterfrom
frewsxcv:fromiterator-example

Conversation

@frewsxcv

@frewsxcvfrewsxcv commented Mar 28, 2015

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

rust-highfive commented Mar 28, 2015

Copy link
Copy Markdown
Contributor

r? @huonw

(rust_highfive has picked a reviewer for you, use r? to override)

@bors

bors commented Mar 29, 2015

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #23300) made this pull request unmergeable. Please resolve the merge conflicts.

@frewsxcv
frewsxcvforce-pushed the fromiterator-example branch from b96d6df to b7ae349CompareMarch 29, 2015 01:03
@frewsxcv

frewsxcv commented Mar 29, 2015

Copy link
Copy Markdown
ContributorAuthor

/cc @steveklabnik since this is docs related

@Manishearth

Manishearth commented Mar 29, 2015

Copy link
Copy Markdown
Member

This looks good to me. r=me with or without the following change:

While we're at it, could we have an example that uses collect()? That is the more common use for FromIterator, eg (vec![1,2,3,4]).map(|x| x*x).collect::<Vec<_>>()

@frewsxcv
frewsxcvforce-pushed the fromiterator-example branch from b7ae349 to f6d1ad8CompareMarch 29, 2015 14:28
@frewsxcv

frewsxcv commented Mar 29, 2015

Copy link
Copy Markdown
ContributorAuthor

@Manishearth How's that?

Manishearth
Manishearth reviewed Mar 29, 2015
View reviewed changes
Comment threadsrc/libcore/iter.rs Outdated

@ManishearthManishearthMar 29, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line seems to be a mistake?

@frewsxcvfrewsxcvMar 29, 2015

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. Fixed in latest push

@frewsxcv
frewsxcvforce-pushed the fromiterator-example branch from f6d1ad8 to 8fe7f1fCompareMarch 29, 2015 14:32
@Manishearth

Manishearth commented Mar 29, 2015

Copy link
Copy Markdown
Member

@bors: r+ rollup

@bors

bors commented Mar 29, 2015

Copy link
Copy Markdown
Collaborator

📌 Commit 8fe7f1f has been approved by Manishearth

bors added a commit that referenced this pull request Mar 29, 2015
@bors
Auto merge of#23816- frewsxcv:fromiterator-example, r=Manishearth
c5370be
@bors

bors commented Mar 29, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 8fe7f1f with merge c5370be...

@bors

bors commented Mar 29, 2015

Copy link
Copy Markdown
Collaborator

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt

@bors
bors merged commit 8fe7f1f into rust-lang:masterMar 29, 2015
@frewsxcv
frewsxcv deleted the fromiterator-example branch October 2, 2016 23:07
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@huonwhuonw

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@frewsxcv@rust-highfive@bors@Manishearth@huonw