Uh oh!
There was an error while loading. Please reload this page.
Moved use of box_syntax in TRPL book. - #23822
Conversation
rust-highfive
commented
Mar 29, 2015
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
Manishearth
commented
Mar 29, 2015
This might be deliberate? |
steveklabnik
commented
Mar 29, 2015
Yes, this matters. It's possible that this should be removed and a section should be added in the unstable section though. But just this diff doesn't work. |
tanadeau
commented
Mar 29, 2015
That makes sense. I'll update this PR with a new section about box syntax. |
a81100f to
97fd8acComparetanadeau
commented
Mar 31, 2015
I added a new section about |
bors
commented
Apr 1, 2015
☔ The latest upstream changes (presumably #23936) made this pull request unmergeable. Please resolve the merge conflicts. |
6b12a8a to
44fdbdaComparetanadeau
commented
Apr 2, 2015
I rebased on top of master. |
tanadeau
commented
Apr 2, 2015
@steveklabnik This PR should now be ready for review. |
steveklabnik
commented
Apr 2, 2015
So the content here is good, but the section that uses the gate, about return values, should end up being in the new chapter as well, as it relies on the keyword. |
Create a new section under the Unstable section for `box` syntax and patterns and removed their discussion from the Pointers section.
44fdbda to
00d929dComparetanadeau
commented
Apr 2, 2015
@steveklabnik Done. |
steveklabnik
commented
Apr 2, 2015
@bors: r+ rollup |
bors
commented
Apr 2, 2015
📌 Commit 00d929d has been approved by |
steveklabnik
commented
Apr 2, 2015
Thank you! :D |
bors
commented
Apr 2, 2015
…steveklabnik This is the first use of `box`. It's an unstable feature and also isn't consistent with the use of `Box` in the "original" code above it. r? @steveklabnik
This is the first use of
box. It's an unstable feature and also isn'tconsistent with the use of
Boxin the "original" code above it.r? @steveklabnik