Skip to content

Fix sidebar bug - #23941

Merged
bors merged 1 commit into
rust-lang:masterfrom
carloslfu:patch-1
Apr 4, 2015
Merged

Fix sidebar bug#23941
bors merged 1 commit into
rust-lang:masterfrom
carloslfu:patch-1

Conversation

@carloslfu

@carloslfucarloslfu commented Apr 1, 2015

Copy link
Copy Markdown
Contributor

Validate if the description is available in the rawSearchIndex

@carloslfu
Fix sidebar bug
48aea41
Validate if the description is available in the rawSearchIndex
@rust-highfive

rust-highfive commented Apr 1, 2015

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@steveklabnik

steveklabnik commented Apr 1, 2015

Copy link
Copy Markdown
Contributor

What specifically does this fix?

@carloslfu

carloslfu commented Apr 2, 2015

Copy link
Copy Markdown
ContributorAuthor

When a crate don't have items, an error stops the rendering of sidebar. I found this in the servo generated docs

@steveklabnik

steveklabnik commented Apr 2, 2015

Copy link
Copy Markdown
Contributor

Ahhh gotcha, thanks!

@steveklabnik

steveklabnik commented Apr 2, 2015

Copy link
Copy Markdown
Contributor

@bors: r+ rollup

@bors

bors commented Apr 2, 2015

Copy link
Copy Markdown
Collaborator

📌 Commit 48aea41 has been approved by steveklabnik

Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 3, 2015
@Manishearth
Rollup merge ofrust-lang#23941- carloslfu:patch-1, r=steveklabnik
cdc5187
Validate if the description is available in the rawSearchIndex
@ManishearthManishearth mentioned this pull request Apr 3, 2015
Merged
bors added a commit that referenced this pull request Apr 3, 2015
@bors
Auto merge of#24009- Manishearth:rollup, r=Manishearth
f77cb26
- Successful merges: #23930, #23941, #23972, #23976, #23978, #23993, #23995, #23997, #24005
- Failed merges:
Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 4, 2015
@Manishearth
Rollup merge ofrust-lang#23941- carloslfu:patch-1, r=steveklabnik
9fc7a1e
 Validate if the description is available in the rawSearchIndex
@bors
bors merged commit 48aea41 into rust-lang:masterApr 4, 2015
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@steveklabniksteveklabnik

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@carloslfu@rust-highfive@steveklabnik@bors