Uh oh!
There was an error while loading. Please reload this page.
Remove old_io from trpl/concurrency.md - #24031
Conversation
Also: the std_misc feature flag is removed; it's not needed in Beta. Hat tip to @tshepang in rust-lang#23871Fixesrust-lang#24023
rust-highfive
commented
Apr 3, 2015
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
callahad
commented
Apr 3, 2015
Doh, forgot about @rust-highfive's auto-assignment. Per Steve's comment in #24024: |
steveklabnik
commented
Apr 3, 2015
@bors: r+ rollup |
bors
commented
Apr 3, 2015
📌 Commit 3b73a6e has been approved by |
steveklabnik
commented
Apr 3, 2015
Thank you! In the future, you don't need a new PR to do this: http://blog.steveklabnik.com/posts/2012-11-08-how-to-squash-commits-in-a-github-pull-request |
callahad
commented
Apr 3, 2015
steveklabnik
commented
Apr 3, 2015
Yup! :) |
…veklabnik Also: the std_misc feature flag is removed; it's not needed in Beta. Hat tip to @tshepang in rust-lang#23871Fixesrust-lang#24023 This PR replaces rust-lang#24024
Manishearth
commented
Apr 4, 2015
Needs Manishearth@b62c110 to pass |
callahad
commented
Apr 4, 2015
@Manishearth I'm still super unfamiliar with the Rust contrib process. Do I need to take any action (adding / squashing your commit into this PR), or is your fixup going to get handled elsewhere? |
Manishearth
commented
Apr 4, 2015
Oh, sorry. So your PR is included in the current rollup (big ball of PRs to push through the CI), including this fix. If all goes well you don't have to worry. However, if the rollup fails or is abandoned, the next time this gets built it will fail. I suggest you cherrypick that commit into your PR and leave it like that :) |
Manishearth
commented
Apr 4, 2015
(It merged now, so you don't need to do anything) |

Also: the std_misc feature flag is removed; it's not needed in Beta.
Hat tip to @tshepang in #23871
Fixes#24023
This PR replaces #24024