Uh oh!
There was an error while loading. Please reload this page.
Fix range performance regression - #24120
Merged
Merged
Conversation
alexcrichton
commented
Apr 6, 2015
Member
bors
commented
Apr 7, 2015
Collaborator
⌛ Testing commit b5301e6 with merge 6f22c6a... |
bors
commented
Apr 7, 2015
Collaborator
💔 Test failed - auto-mac-32-opt |
A recent change to the implementation of range iterators meant that, even when stepping by 1, the iterators *always* involved checked arithmetic. This commit reverts to the earlier behavior (while retaining the refactoring into traits). Fixesrust-lang#24095 cc rust-lang#24014
aturon
commented
Apr 7, 2015
ContributorAuthor
@bors: r=alexcrichton |
bors
commented
Apr 7, 2015
Collaborator
📌 Commit dddcbcf has been approved by |
bors
commented
Apr 8, 2015
Collaborator
bors added a commit
that referenced
this pull request
Apr 8, 2015
A recent change to the implementation of range iterators meant that, even when stepping by 1, the iterators *always* involved checked arithmetic. This commit reverts to the earlier behavior (while retaining the refactoring into traits). Fixes#24095Closes#24119 cc #24014 r? @alexcrichton
bors
commented
Apr 8, 2015
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent change to the implementation of range iterators meant that,
even when stepping by 1, the iterators always involved checked
arithmetic.
This commit reverts to the earlier behavior (while retaining the
refactoring into traits).
Fixes#24095
Closes#24119
cc #24014
r? @alexcrichton