Skip to content

Ensure that .join().unwrap() works - #24254

Merged
bors merged 1 commit into
rust-lang:masterfrom
aturon:join-handle-debug
Apr 11, 2015
Merged

Ensure that .join().unwrap() works#24254
bors merged 1 commit into
rust-lang:masterfrom
aturon:join-handle-debug

Conversation

@aturon

Copy link
Copy Markdown
Contributor

Make Box<Any + Send> implement Debug.

Fixes#21291

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

Makes `Any + Send` implement `Debug`.
Fixesrust-lang#21291
@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+ 76d468a

@reem

reem commented Apr 10, 2015

Copy link
Copy Markdown
Contributor

Won't this mean panic messages will be lost? Or are those still printed?

Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 10, 2015
Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 10, 2015
@alexcrichton

Copy link
Copy Markdown
Member

@reem the panic messages are still printed yeah, controlling that behavior would be nice though!

bors added a commit that referenced this pull request Apr 11, 2015
Make `Box<Any + Send>` implement `Debug`.
Fixes#21291
@bors

bors commented Apr 11, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 76d468a with merge 3a82753...

@bors

bors commented Apr 11, 2015

Copy link
Copy Markdown
Collaborator

@bors
bors merged commit 76d468a into rust-lang:masterApr 11, 2015
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Err from thread should implement Show

5 participants

@aturon@rust-highfive@alexcrichton@reem@bors