Uh oh!
There was an error while loading. Please reload this page.
Changed the wording of the documentation for the insert method for Vec ... - #24279
Merged
Conversation
…c to be less confusing. Since 0 is the smallest number possible for usize, it doesn't make sense to mention it if it's already included, and it should be more clear that the length of the vector is a valid index with the new wording.
rust-highfive
commented
Apr 10, 2015
Contributor
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
steveklabnik
commented
Apr 10, 2015
Contributor
@bors: r+ |
bors
commented
Apr 10, 2015
Collaborator
📌 Commit cdce32f has been approved by |
steveklabnik
commented
Apr 10, 2015
Contributor
@bors: rollup |
steveklabnik
commented
Apr 10, 2015
Contributor
Thank you! |
libfud
commented
Apr 10, 2015
Author
No problem, more than happy to contribute, even if it's a diff of two lines. |
steveklabnik
commented
Apr 10, 2015
Contributor
No diff is too small! |
steveklabnik added a commit
to steveklabnik/rust
that referenced
this pull request
Apr 10, 2015
…labnik ...to be less confusing. Since 0 is the smallest number possible for usize, it doesn't make sense to mention it if it's already included, and it should be more clear that the length of the vector is a valid index with the new wording. r? @steveklabnik
steveklabnik added a commit
to steveklabnik/rust
that referenced
this pull request
Apr 10, 2015
…labnik ...to be less confusing. Since 0 is the smallest number possible for usize, it doesn't make sense to mention it if it's already included, and it should be more clear that the length of the vector is a valid index with the new wording. r? @steveklabnik
steveklabnik added a commit
to steveklabnik/rust
that referenced
this pull request
Apr 10, 2015
…labnik ...to be less confusing. Since 0 is the smallest number possible for usize, it doesn't make sense to mention it if it's already included, and it should be more clear that the length of the vector is a valid index with the new wording. r? @steveklabnik
Manishearth added a commit
to Manishearth/rust
that referenced
this pull request
Apr 11, 2015
…labnik ...to be less confusing. Since 0 is the smallest number possible for usize, it doesn't make sense to mention it if it's already included, and it should be more clear that the length of the vector is a valid index with the new wording. r? @steveklabnik
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...to be less confusing. Since 0 is the smallest number possible for usize, it doesn't make sense to mention it if it's already included, and it should be more clear that the length of the vector is a valid index with the new wording.
r? @steveklabnik