Typeck highlevel before bodies by pnkfelix · Pull Request #24422 · rust-lang/rust

pnkfelix · 2015-04-14T16:53:03Z

typeck: Do high-level structural/signature checks before function body checks.

This avoids various ICEs, e.g. premature calls to cat_expr that yield the dreaded "cat_expr Errd" ICE.

However, it also means that some early error feedback is now not provided. This may be for the best, because the error feedback were were providing in some of those cases were false positives -- it was spurious feedback and a distraction from the real problem.

So it is not 100% clear whether we actually want to put this change in or not. I think its a net win, but others might disagree.

(Kudos to @arielb1 for suggesting this modification.)

…y checks. This avoids various ICEs, e.g. premature calls to cat_expr that yield the dreaded "cat_expr Errd" ICE.

Closerust-lang#23729Closerust-lang#23827Closerust-lang#24356

rust-highfive · 2015-04-14T16:53:08Z

r? @pcwalton

(rust_highfive has picked a reviewer for you, use r? to override)

pnkfelix · 2015-04-14T16:53:10Z

r? @nikomatsakis

nagisa · 2015-04-14T20:10:13Z

👍 this PR just for this.

ebfull · 2015-04-14T20:50:38Z

Nice!

lilyball · 2015-04-15T16:39:59Z

Conceptually, I like this change. I'd rather debug the high-level structural issues first, especially as issues in function bodies may actually just be symptoms of high-level issues.

nikomatsakis · 2015-04-16T17:56:07Z

r+

I've been thinking about doing exactly this, actually, so happy that you beat me to it. (The other thing I have been considering is adding some kind of rough dependency analysis so we can type-check callees before callers.)

nikomatsakis · 2015-04-16T17:57:33Z

Note though that we already have the wf pass, which is supposed to be exactly this distinction of signatures vs bodies. It was introduced because forcing types to have the right annotations avoided a lot of spurious errors. Note sure if it makes sense to keep the "three-phases". I think i'm inclined to r+ it as is but gradually refactor check/mod to break it up and make the pass structure clearer.

pnkfelix · 2015-04-17T00:05:40Z

@bors r=nikomatsakis

bors · 2015-04-17T00:05:40Z

📌 Commit d82f912 has been approved by nikomatsakis

bors · 2015-04-17T03:47:41Z

⌛ Testing commit d82f912 with merge 971440a...

bors · 2015-04-17T03:50:29Z

⛄ The build was interrupted to prioritize another pull request.

bors · 2015-04-17T03:50:31Z

⌛ Testing commit d82f912 with merge 7fbedc5...

@arielb1

…omatsakis typeck: Do high-level structural/signature checks before function body checks. This avoids various ICEs, e.g. premature calls to cat_expr that yield the dreaded "cat_expr Errd" ICE. However, it also means that some early error feedback is now not provided. This may be for the best, because the error feedback were were providing in some of those cases were false positives -- it was spurious feedback and a distraction from the real problem. So it is not 100% clear whether we actually want to put this change in or not. I think its a net win, but others might disagree. (Kudos to @arielb1 for suggesting this modification.)

bors · 2015-04-17T05:52:33Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt

pnkfelix · 2015-04-23T21:46:02Z

normally we would not (should not) accept a change like this for beta, but, since this (1.) fixes ICEs (2.) is a user-experience improvement, and (3.) is pretty low-risk, we are taking it just because 1.0 release is a special case

going from nominated to (nominated, accepted)

pnkfelix added 3 commits April 14, 2015 11:20

typeck: Do high-level structural/signature checks before function bod…
32d5f74
…y checks. This avoids various ICEs, e.g. premature calls to cat_expr that yield the dreaded "cat_expr Errd" ICE.

Regression tests for issues that led me to revise typeck.
58dc3bb
Closerust-lang#23729Closerust-lang#23827Closerust-lang#24356

Fallout from this change.
d82f912

rust-highfive assigned pcwalton Apr 14, 2015

rust-highfive assigned nikomatsakis and unassigned pcwalton Apr 14, 2015

pnkfelix mentioned this pull request Apr 14, 2015
Delay specific span_bug() call until abort_if_errors() #24367
Merged

nagisa reviewed Apr 14, 2015
View reviewed changes

Comment threadsrc/test/compile-fail/associated-types-no-suitable-supertrait.rs
nagisaApr 14, 2015
Copy link
Copy Markdown
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 this PR just for this.

bors merged commit d82f912 into rust-lang:masterApr 17, 2015

pnkfelix added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 21, 2015

alexcrichton mentioned this pull request Apr 23, 2015
Cherry-picking beta-nominated in to beta #24708
Merged

pnkfelix added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Apr 23, 2015

alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 23, 2015

Uh oh!

Uh oh!

Conversation

pnkfelix commented Apr 14, 2015

Uh oh!

rust-highfive commented Apr 14, 2015

Uh oh!

pnkfelix commented Apr 14, 2015

Uh oh!

nagisaApr 14, 2015

Choose a reason for hiding this comment

Uh oh!

ebfull commented Apr 14, 2015

Uh oh!

lilyball commented Apr 15, 2015

Uh oh!

nikomatsakis commented Apr 16, 2015

Uh oh!

nikomatsakis commented Apr 16, 2015

Uh oh!

pnkfelix commented Apr 17, 2015

Uh oh!

bors commented Apr 17, 2015

Uh oh!

bors commented Apr 17, 2015

Uh oh!

bors commented Apr 17, 2015

Uh oh!

bors commented Apr 17, 2015

Uh oh!

bors commented Apr 17, 2015

Uh oh!

pnkfelix commented Apr 23, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants