configure: Don't succeed if valgrind isn't available. Fixes #18588

[brson]

Based on @emanueLczirai's patch.

r? @nrc

[apasel422]

s/it's/its/

[nrc]

r+, I guess with the typo fixed

[brson]

@bors r=nrc rollup

[bors]

📌 Commit 31856a5 has been approved by nrc

[Manishearth]

Can valgrind be disabled by default in the configure? IMO ./configure should generally just work on common systems, and valgrind is usually not there out of the box.

[bors]

⌛ Testing commit 31856a5 with merge e75d39d...

[bors]

💔 Test failed - auto-win-64-nopt-t

[Manishearth]

configure: error: valgrind not found, but needed. consider adding --disable-valgrind-rpass
program finished with exit code 1
elapsedTime=2.558000

[ghost]

One thing to note is that --disable-valgrind doesn't imply --disable-valgrind-rpass as far as I remember. It seemed to me, it was intended this way from the beginning.
The relevant "discussion" is here: #18588 (comment)

[steveklabnik]

@bors: r-

[steveklabnik]

@brson: now that #24859 is merged, is this PR needed?

[brson]

I think it is not.