Uh oh!
There was an error while loading. Please reload this page.
Use BTreeMap in build_sidebar_items - #24494
Conversation
This ensures that later when generating HTML, the JSON will be sorted aswell. We now have a deterministic build of sidebar-items.js
rust-highfive
commented
Apr 16, 2015
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
alexcrichton
commented
Apr 16, 2015
Does this close #24473? |
mvdnes
commented
Apr 16, 2015
Ah yes! I did not find that issue earlier, but this should address exactly that. |
alexcrichton
commented
Apr 16, 2015
alexcrichton
commented
Apr 16, 2015
@bors: rollup |
…xcrichton This ensures that later when generating HTML, the JSON will be sorted aswell. We now have a more deterministic build of sidebar-items.js Closesrust-lang#24473
…xcrichton This ensures that later when generating HTML, the JSON will be sorted aswell. We now have a more deterministic build of sidebar-items.js Closesrust-lang#24473
…xcrichton This ensures that later when generating HTML, the JSON will be sorted aswell. We now have a more deterministic build of sidebar-items.js Closesrust-lang#24473
steveklabnik
commented
Apr 17, 2015
This was merged in #24512 , sorry, I rebased and forgot that'd screw it up :( |
mvdnes
commented
Apr 28, 2015
Is it possible to put this code in the beta as well? I don't think anyone would mind. |
This ensures that later when generating HTML, the JSON will be sorted aswell.
We now have a more deterministic build of sidebar-items.js
Closes#24473