Uh oh!
There was an error while loading. Please reload this page.
Implement IntoIterator for Receiver - #24633
Conversation
rust-highfive
commented
Apr 20, 2015
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
alexcrichton
commented
Apr 20, 2015
This seems like a good idea to me, so thanks @rapha! This does, however, probably force our hand in having this new functionality be insta- Could you change the imports of |
rapha
commented
Apr 20, 2015
Thanks. I added doc and stability annotations to match those on the Iter type, adding that it was an "owning" iterator. |
rapha
commented
Apr 22, 2015
Do you need me to do anything more on this? |
alexcrichton
commented
Apr 22, 2015
Ah thanks for the reminder @rapha! I intended on just running this by some others to get their opinion as well. I believe now this is good to go! In the meantime, however, we've bumped the version number, so could you update the |
bluss
commented
Apr 22, 2015
Shouldn't it have another IntoIterator impl to match the |
alexcrichton
commented
Apr 22, 2015
@bluss in theory, yes, but it's not necessarily required one way or another as it's backwards compatible to add. @rapha would you be interested in adding this, however? @rapha ah I forgot this part, but you'll also need to choose a unique feature name for this as the same feature name can't have multiple versions it became stable in (e.g. the |
rapha
commented
Apr 23, 2015
@bluss Is this the implementation of IntoIterator for &Receiver what you had in mind? |
There was a problem hiding this comment.
Ah sorry by new feature name I meant more something along the lines of receiver_into_iter or something like that
alexcrichton
commented
Apr 23, 2015
@rapha looks good to me! Could you also squash the commits together? |
rapha
commented
Apr 23, 2015
Done |
bluss
commented
Apr 23, 2015
Yes that's great. It's consistent now that the .iter() method has a corresponding IntoIterator impl, thank you! |
No description provided.