Skip to content

Add two examples for Path::new - #24649

Merged
bors merged 3 commits into
rust-lang:masterfrom
nham:path_new_examples
Apr 25, 2015
Merged

Add two examples for Path::new#24649
bors merged 3 commits into
rust-lang:masterfrom
nham:path_new_examples

Conversation

@nham

@nhamnham commented Apr 21, 2015

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

rust-highfive commented Apr 21, 2015

Copy link
Copy Markdown
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@steveklabnik

steveklabnik commented Apr 21, 2015

Copy link
Copy Markdown
Contributor

Thanks for this! A few nits inline:

steveklabnik
steveklabnik reviewed Apr 21, 2015
View reviewed changes
Comment threadsrc/libstd/path.rs Outdated

@steveklabniksteveklabnikApr 21, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a or colon at the end of this sentence

@steveklabnik

steveklabnik commented Apr 21, 2015

Copy link
Copy Markdown
Contributor

Just some nits! see http://doc.rust-lang.org/nightly/book/documentation.html for some examples of the style

@nham

nham commented Apr 21, 2015

Copy link
Copy Markdown
ContributorAuthor

Sorry, I'm a bit confused on how to add the triple backticks. If these get split into multiple code blocks, will I have to import std::path::Path for each?

@steveklabnik

steveklabnik commented Apr 25, 2015

Copy link
Copy Markdown
Contributor

@nham sorry i missed this notification! This looks great though, thanks.

(and yes, you'd have to import each time, they're totally separate examples.

@steveklabnik

steveklabnik commented Apr 25, 2015

Copy link
Copy Markdown
Contributor

@bors: r+ rollup

@bors

bors commented Apr 25, 2015

Copy link
Copy Markdown
Collaborator

📌 Commit ba4d55d has been approved by steveklabnik

Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 25, 2015
@Manishearth
Rollup merge ofrust-lang#24649- nham:path_new_examples, r=steveklabnik
4f1bbc2
@ManishearthManishearth mentioned this pull request Apr 25, 2015
Merged
bors added a commit that referenced this pull request Apr 25, 2015
@bors
Auto merge of#24813- Manishearth:rollup, r=Manishearth
b6f6975
- Successful merges: #24649, #24806, #24809, #24811
- Manual merges: #24812
@bors

bors commented Apr 25, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit ba4d55d with merge de37e90...

Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 25, 2015
@Manishearth
add import (fixuprust-lang#24649)
3e67b6b
@bors

bors commented Apr 25, 2015

Copy link
Copy Markdown
Collaborator

⛄ The build was interrupted to prioritize another pull request.

@bors

bors commented Apr 25, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit ba4d55d with merge f1328ba...

@bors

bors commented Apr 25, 2015

Copy link
Copy Markdown
Collaborator

⛄ The build was interrupted to prioritize another pull request.

bors added a commit that referenced this pull request Apr 25, 2015
@bors
Auto merge of#24813- Manishearth:rollup, r=Manishearth
0d8309e
- Successful merges: #24649, #24806, #24809, #24811
- Manual merges: #24812
@bors
bors merged commit ba4d55d into rust-lang:masterApr 25, 2015
@steveklabniksteveklabnik mentioned this pull request May 10, 2015
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@aturonaturon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nham@rust-highfive@steveklabnik@bors@aturon