Uh oh!
There was an error while loading. Please reload this page.
Reference Manual Chapter 8.1 - #24744
Conversation
rust-highfive
commented
Apr 23, 2015
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
There was a problem hiding this comment.
So, the unit type has actually been removed, () is only an empty tuple.
There was a problem hiding this comment.
Yes, ok, that's the simplest way to go
steveklabnik
commented
Apr 23, 2015
Generally 👍 , but some nits! |
bluss
commented
Apr 23, 2015
Will update with new commits, then squash after review. I don't mind lots of iterations. |
bluss
commented
Apr 24, 2015
(Updated to address both nits) |
steveklabnik
commented
Apr 24, 2015
r=me after a squash, thanks so much! |
- Remove mention of unit type - Update closure types and reference types sections - Fix minor typos
bluss
commented
Apr 24, 2015
Done, thanks for the feedback! |
steveklabnik
commented
Apr 24, 2015
@bors: r+ |
bors
commented
Apr 24, 2015
📌 Commit b22ea2d has been approved by |
steveklabnik
commented
Apr 24, 2015
@bors: rollup |
bors
commented
Apr 24, 2015
Audit & Edit Chapter 8.1 Types in reference manual - Remove mention of unit type - Update closure types and reference types sections - Fix minor typos
Audit & Edit Chapter 8.1 Types in reference manual