Skip to content

Add feature gate tests - #24749

Merged
bors merged 4 commits into
rust-lang:masterfrom
lgrz:feature-gate-22820
Apr 25, 2015
Merged

Add feature gate tests#24749
bors merged 4 commits into
rust-lang:masterfrom
lgrz:feature-gate-22820

Conversation

@lgrz

@lgrzlgrz commented Apr 23, 2015

Copy link
Copy Markdown
Contributor

As part of the audit for #22820 the following feature gate tests have been
added:

  • negate_unsigned
  • on_unimplemented
  • optin_builtin_traits
  • plugin
  • rustc_attrs
  • rustc_diagnostic_macros
  • slice_patterns

In addition some feature gate error message typos fixed.

@rust-highfive

rust-highfive commented Apr 23, 2015

Copy link
Copy Markdown
Contributor

r? @nrc

(rust_highfive has picked a reviewer for you, use r? to override)

@nrc

nrc commented Apr 23, 2015

Copy link
Copy Markdown
Member

It looks to me like a couple of tests got renamed when they should have been copied, the end result is we lose two tests. Is that accidental or deliberate?

@lgrz

lgrz commented Apr 23, 2015

Copy link
Copy Markdown
ContributorAuthor

Thanks, I was just about to comment on this. The diff on Github shows files as being renamed, however the individual commits themselves do no such thing. Not sure what happened, I'll look into this further.

@lgrz

lgrz commented Apr 23, 2015

Copy link
Copy Markdown
ContributorAuthor

There is a commit that deletes some duplicate tests (1ec6bb7) and these deleted files are showing up as being renamed in the diff on Github. But locally a git diff feature-gate-22820...master shows up fine (without the renaming).

I am going to split out the deletions and submit them as a separate PR as having the rename in the history on Github is not the intended meaning of the changeset. Hopefully that will make the changes appear as intended on Github.

@lgrz

lgrz commented Apr 24, 2015

Copy link
Copy Markdown
ContributorAuthor

Sorry there was an error in that latest push, fixing now...

lgrz added 4 commits April 24, 2015 10:10
@lgrz
Add missing '\' for custom_derive error message
e0b4c37
@lgrz
Add ')' in advaced_slice_patterns error message
12e30f7
@lgrz
Add feature gate tests
03ff281
As part of the audit for #22820 the following feature gate tests have
been added:
* `negate_unsigned`
* `on_unimplemented`
* `optin_builtin_traits`
* `plugin`
* `rustc_attrs`
* `slice_patterns`
@lgrz
Add feature gate tests
0cae315
As part of the audit for #22820 the following feature gate tests have
been added:
* `rustc_diagnostic_macros`
/cc #19624
@lgrz

lgrz commented Apr 24, 2015

Copy link
Copy Markdown
ContributorAuthor

Ok, sorry about mixup there, I've removed the duplicate tests that were deleted from this PR, I will submit them in a separate PR. Thanks.

@lgrzlgrz mentioned this pull request Apr 24, 2015
Merged
@nrc

nrc commented Apr 24, 2015

Copy link
Copy Markdown
Member

@bors r+ 0cae315 rollup

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Apr 25, 2015
@steveklabnik
Rollup merge ofrust-lang#24749- lstat:feature-gate-22820, r=nrc
1385472
As part of the audit for rust-lang#22820 the following feature gate tests have been
added:
* `negate_unsigned`
* `on_unimplemented`
* `optin_builtin_traits`
* `plugin`
* `rustc_attrs`
* `rustc_diagnostic_macros`
* `slice_patterns`
In addition some feature gate error message typos fixed.
@steveklabniksteveklabnik mentioned this pull request Apr 25, 2015
Merged
bors added a commit that referenced this pull request Apr 25, 2015
@bors
Auto merge of#24798- steveklabnik:rollup, r=steveklabnik
a40261a
- Successful merges: #24662, #24722, #24725, #24729, #24736, #24749, #24751, #24766, #24769, #24772, #24775, #24790
- Failed merges: #24760
@bors
bors merged commit 0cae315 into rust-lang:masterApr 25, 2015
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nrcnrc

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lgrz@rust-highfive@nrc@bors