Skip to content

collections: Examples for as_string and as_vec - #24848

Merged
bors merged 1 commit into
rust-lang:masterfrom
bluss:deref-string
Apr 27, 2015
Merged

collections: Examples for as_string and as_vec#24848
bors merged 1 commit into
rust-lang:masterfrom
bluss:deref-string

Conversation

@bluss

Copy link
Copy Markdown
Contributor

Improve example for as_string and add example for as_vec

Provide a better example of as_string / DerefString's unique capabilities.
Use an example where (for an unspecified reason) you need a &String, and
show how as_string solves the problem without needing an allocation.

@rust-highfive

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@bluss

Copy link
Copy Markdown
ContributorAuthor

Last time this came up I didn't communicate clearly enough why this function needed a (seemingly) silly example #19628. Don't "fix" it to lose the point of this peculiar function this time. 😄

@blussbluss changed the title collections: Improve example for as_stringcollections: Examples for as_string and as_vecApr 26, 2015
Comment threadsrc/libcollections/string.rs Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

&String should be in `s

@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+ 84ef3b5 rollup

Thanks!

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Apr 27, 2015
Improve example for as_string and add example for as_vec
Provide a better example of `as_string` / `DerefString`'s unique capabilities.
Use an example where (for an unspecified reason) you need a &String, and
show how `as_string` solves the problem without needing an allocation.
bors added a commit that referenced this pull request Apr 27, 2015
@bors
bors merged commit 84ef3b5 into rust-lang:masterApr 27, 2015
@bluss
bluss deleted the deref-string branch April 27, 2015 16:47
@steveklabniksteveklabnik mentioned this pull request May 10, 2015
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@bluss@rust-highfive@alexcrichton@steveklabnik@bors