Skip to content

Implement append and split_off for BitVec (RFC 509) - #24890

Merged
bors merged 1 commit into
rust-lang:masterfrom
jooert:bitvec-append-split_off
May 7, 2015
Merged

Implement append and split_off for BitVec (RFC 509)#24890
bors merged 1 commit into
rust-lang:masterfrom
jooert:bitvec-append-split_off

Conversation

@jooert

Copy link
Copy Markdown
Contributor

Comment threadsrc/libcollections/bit.rs Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd appreciate a more useful name than b.

@Gankra

Copy link
Copy Markdown
Contributor

Sorry for the delayed response. Review done!

@jooert
jooertforce-pushed the bitvec-append-split_off branch from a2f1c3f to fb9419aCompareApril 29, 2015 22:04
@jooert

Copy link
Copy Markdown
ContributorAuthor

Thank you for your review! I fixed everything you noted, except for the assertion regarding the internal representation and the feature gate.

@Gankra

Copy link
Copy Markdown
Contributor

Alright, r=me with the feature gate fixed (which I'll go ping someone to get an answer on).

@jooert
jooertforce-pushed the bitvec-append-split_off branch from fb9419a to 7311394CompareMay 5, 2015 16:56
@jooert

Copy link
Copy Markdown
ContributorAuthor

I have changed the name of the feature gate to bit_vec_append_split_off. So everything should be fine now.

Comment threadsrc/libcollections/bit.rs Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the feature list in this documentation (and the above example) will need to be updated. You can also be sure to run these tests with make check-stage2-doc-crate-collections

@jooert
jooertforce-pushed the bitvec-append-split_off branch from 7311394 to 9fa6e4cCompareMay 5, 2015 21:38
@jooert

Copy link
Copy Markdown
ContributorAuthor

@alexcrichton Fixed everything you noted and had to update the call to Vec::drain since it takes a range parameter now.

@alexcrichton

Copy link
Copy Markdown
Member

@bors: r=Gankro 9fa6e4c

Thanks @jooert!

@bors

bors commented May 6, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 9fa6e4c with merge 3d544f2...

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jooert@Gankra@alexcrichton@bors