Uh oh!
There was an error while loading. Please reload this page.
Implement append and split_off for BitVec (RFC 509) - #24890
Conversation
There was a problem hiding this comment.
I'd appreciate a more useful name than b.
Gankra
commented
Apr 29, 2015
Sorry for the delayed response. Review done! |
a2f1c3f to
fb9419aComparejooert
commented
Apr 29, 2015
Thank you for your review! I fixed everything you noted, except for the assertion regarding the internal representation and the feature gate. |
Gankra
commented
Apr 30, 2015
Alright, r=me with the feature gate fixed (which I'll go ping someone to get an answer on). |
fb9419a to
7311394Comparejooert
commented
May 5, 2015
I have changed the name of the feature gate to |
There was a problem hiding this comment.
I think the feature list in this documentation (and the above example) will need to be updated. You can also be sure to run these tests with make check-stage2-doc-crate-collections
7311394 to
9fa6e4cComparejooert
commented
May 5, 2015
@alexcrichton Fixed everything you noted and had to update the call to Vec::drain since it takes a range parameter now. |
alexcrichton
commented
May 5, 2015
bors
commented
May 6, 2015
⌛ Testing commit 9fa6e4c with merge 3d544f2... |
cc #19986
r? @gankro