Uh oh!
There was an error while loading. Please reload this page.
Remove #[static_assert] - #24910
Merged
Merged
Conversation
rust-highfive
commented
Apr 28, 2015
Contributor
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
strega-nil
commented
Apr 28, 2015
Contributor
👍 |
steveklabnik
commented
Apr 28, 2015
ContributorAuthor
Brought this up in the meeting, RFC incoming |
steveklabnik
commented
Apr 28, 2015
ContributorAuthor
Filed: rust-lang/rfcs#1096 |
bors
commented
May 7, 2015
Collaborator
☔ The latest upstream changes (presumably #25175) made this pull request unmergeable. Please resolve the merge conflicts. |
This was always a weird feature, and isn't being used in the compiler. Static assertions should be done better than this. This implements RFC rust-lang#1096. Fixesrust-lang#13951Fixesrust-lang#23008Fixesrust-lang#6676 This is behind a feature gate, but that's still a [breaking-change]
steveklabnikforce-pushed
the
remove_static_assert
branch
from
June 3, 2015 13:38
c446e30 to
5235065Comparesteveklabnik
commented
Jun 3, 2015
ContributorAuthor
@nikomatsakis I have rebased this PR. |
alexcrichton
commented
Jun 3, 2015
Member
bors added a commit
that referenced
this pull request
Jun 3, 2015
This was always a weird feature, and isn't being used in the compiler. Static assertions should be done better than this. Fixes#13951Fixes#23008Fixes#6676 This is behind a feature gate, but that's still a [breaking-change] (It's not entirely clear to me that this should or shouldn't have an RFC, but if it does, I'm fine blocking on such a thing.)
bors
commented
Jun 3, 2015
Collaborator
bors
commented
Jun 3, 2015
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was always a weird feature, and isn't being used in the compiler.
Static assertions should be done better than this.
Fixes#13951
Fixes#23008
Fixes#6676
This is behind a feature gate, but that's still a
[breaking-change]
(It's not entirely clear to me that this should or shouldn't have an RFC, but if it does, I'm fine blocking on such a thing.)