Uh oh!
There was an error while loading. Please reload this page.
bitflags! uses associated constants - #24921
Merged
Merged
Conversation
alexcrichton
commented
Apr 29, 2015
Member
Now that #24888 has landed, could you rebase this as well? |
tamirdforce-pushed
the
bitflags-associated-const
branch
from
April 29, 2015 15:55
5e3e3a5 to
8c58fe1Comparealexcrichton
commented
Apr 29, 2015
Member
Fascinating! Were the changes from constants like |
tamird
commented
Apr 29, 2015
ContributorAuthor
Done! |
tamird
commented
Apr 29, 2015
ContributorAuthor
@alexcrichton stylistic :) |
tamird
commented
Apr 29, 2015
ContributorAuthor
It's probably a bit of an anti-pattern to have a constant that represents the empty set of flags, since |
alexcrichton
commented
Apr 29, 2015
Member
Yeah it looks like there's a number of stylistic things that may want to be tweaked now that the flags are scoped. For example all of the LLVM attributes end with |
Merged
alexcrichton added a commit
to alexcrichton/rust
that referenced
this pull request
Apr 29, 2015
Conflicts: src/librustc/lib.rs
bors added a commit
that referenced
this pull request
May 7, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #24888. r? @alexcrichton