Simple formatting of some modules

[nrc]

Done automatically with rustfmt.

[rust-highfive]

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

[bors]

☔ The latest upstream changes (presumably #24967) made this pull request unmergeable. Please resolve the merge conflicts.

[tbu-]

I think you should also support the style of function as it was before.

[pnkfelix]

I do like having the whole fn sig and body in one line when the body really is short. Is this hard to accommodate, @nrc ? Or is this more of a philosophical thing about "bodies should be presented separately from signatures" ?

[nrc]

It's a bit of both tbh, I do prefer function bodies always having their own line - makes it easier to read and distinguish provided from required methods. It was also the easiest thing to do.

[pnkfelix]

Overall this looks reasonable. There were some nits noted above.

@nrc maybe you should do another pass with your fixed rustfmt and force-push that, so that we can clearly distinguish the manual fixups to graphviz from the fixes to rustfmt? In particular some of the previous deltas were clear bugs, and I want to just double-check that those were indeed fixed.

[bluss]

I don't like this where placement. It's doesn't scale well to multiple lines in the where clause.

fnwith_no_errors<T,F>(&mutself,f:F) -> TwhereF:FnOnce(&mutResolver) -> T,T:MoreBoundsHere,

Mostly the question is: What does the more complicated where clause look like. Bunched up on one line the docs is not acceptable, we need readable & diffable :-)

[nrc]

It scales to:

fn with_no_errors<T, F>(&mut self, f: F) -> T where
where F: FnOnce(&mut Resolver) -> T,
T: MoreBoundsHere,

I find that easier to scan because you see the where keyword when scanning down the lhs

[bluss]

I think it's ok.

Are we free to choose any style even if dumb editors may make it hard to replicate? I guess rustfmt can fix it. I'm sure I can get Vim to do this style, but it's a tedious style to space out manually for those with dumber editors or those that just don't install rust plugins.

[nrc]

@pnkfelix rebased and, as suggested, manual fixups separated out better

[ghost]

This feels strange since the curly braces normally open at the end of the function signature, but here it's on it's own line. I understand why it's done, but there's a definite aesthetic dissonance.

[bors]

☔ The latest upstream changes (presumably #25171) made this pull request unmergeable. Please resolve the merge conflicts.

[alexcrichton]

Closing due to inactivity, but looking forward to possibly using rustfmt in the future!