Skip to content

Lint: warn when mixing #[repr(C)] with Drop - #24935

Merged
bors merged 2 commits into
rust-lang:masterfrom
pnkfelix:lint-repr-c-drop
Apr 30, 2015
Merged

Lint: warn when mixing #[repr(C)] with Drop#24935
bors merged 2 commits into
rust-lang:masterfrom
pnkfelix:lint-repr-c-drop

Conversation

@pnkfelix

@pnkfelixpnkfelix commented Apr 29, 2015

Copy link
Copy Markdown
Contributor

Lint: warn when mixing #[repr(C)] with Drop

Fix#24585

@rust-highfive

rust-highfive commented Apr 29, 2015

Copy link
Copy Markdown
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

huonw
huonw reviewed Apr 29, 2015
View reviewed changes
Comment threadsrc/librustc_lint/builtin.rs Outdated

@huonwhuonwApr 29, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we generally start compiler messages with a lower case.

@huonwhuonwApr 29, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this message could also be rephrased slightly, maybe:

implementing Drop adds hidden state to a struct, possibly conflicting with the #[repr(C)] attribute

@pnkfelixpnkfelixApr 29, 2015

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't like the fact that I was referring solely to "structs" anyway, when this is slightly more general than that. So, that's fixed now. :)

@alexcrichton

alexcrichton commented Apr 29, 2015

Copy link
Copy Markdown
Member

Just a few minor nits, otherwise r=me though. Thanks @pnkfelix!

@pnkfelix
lint for mixing #[repr(C)] with an impl of Drop.
78130a4
@pnkfelix
tests for lint that warns about mixing #[repr(C)] with Drop.
2e23d81
THis includes tests for struct and enum. (I suspect the closure case
is actually unreachable, but i see no harm in including it.)
@pnkfelix

pnkfelix commented Apr 29, 2015

Copy link
Copy Markdown
ContributorAuthor

@bors r=alexcrichton 2e23d81 rollup

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Apr 29, 2015
@alexcrichton
rollup merge ofrust-lang#24935: pnkfelix/lint-repr-c-drop
373d620
Lint: warn when mixing `#[repr(C)]` with Drop
Fixrust-lang#24585
@bors
bors merged commit 2e23d81 into rust-lang:masterApr 30, 2015
@pnkfelix

pnkfelix commented Apr 30, 2015

Copy link
Copy Markdown
ContributorAuthor

triage: beta-nominated

@rust-highfiverust-highfive added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 30, 2015
@pnkfelix

pnkfelix commented Apr 30, 2015

Copy link
Copy Markdown
ContributorAuthor

accepted for backport to beta channel.

(this is special case for 1.0; post 1.0 a change like this might need stronger motivation...)

@pnkfelixpnkfelix added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Apr 30, 2015
@alexcrichtonalexcrichton mentioned this pull request Apr 30, 2015
Merged
@brsonbrson removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 30, 2015
@brson

brson commented Apr 30, 2015

Copy link
Copy Markdown
Contributor

Backported.

@alexcrichtonalexcrichton mentioned this pull request May 1, 2015
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexcrichtonalexcrichton

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The Drop flag is a footgun for #[repr(C)]

6 participants

@pnkfelix@rust-highfive@alexcrichton@brson@huonw@bors