Uh oh!
There was an error while loading. Please reload this page.
TRPL: guessing game - #25080
Conversation
rust-highfive
commented
May 3, 2015
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
killercup
commented
May 3, 2015
Good read. I've added a few comments for questions and typos. Feel free to ignore my stylistic suggestions :) |
steveklabnik
commented
May 3, 2015
Thanks @killercup and @parir ! nits addressed |
There was a problem hiding this comment.
Perhaps "does not yet"? (we do plan on including it one day)
There was a problem hiding this comment.
It's hard. Text like that tends to get out of date, though I guess this phrasing does too. Hrm.
alexcrichton
commented
May 4, 2015
Amazing @steveklabnik! Only a few stylistic nits from me, but otherwise r=me |
steveklabnik
commented
May 4, 2015
Woot! About to board a plane, but I'll get on it tomorrow. I gotta get used to linking to more docs :) |
There was a problem hiding this comment.
NB. if the code above is changed to rand = "0.3" this section will need updating.
There was a problem hiding this comment.
Will it? rand = 0.3 will use 0.4 when it comes out, just like this.
There was a problem hiding this comment.
The specification "0.3" to cargo indicates "0.3 compatible" and because 0.4 is not compatible with 0.3 it won't automatically pick it up (e.g. I believe @huonw is correct here)
There was a problem hiding this comment.
"0.3.0" is shorthand for "^0.3.0" still, right? That should pick up 0.4.0, to be compatible with ^ requirements. It won't pick up a 1.0.0.
There was a problem hiding this comment.
Yes, but 0.3.0 is not semver compatible with 0.4.0, so it won't pick it up
There was a problem hiding this comment.
Where's this behavior documented? Breaking ^ seems really bad :/
There was a problem hiding this comment.
Cargo takes 0.x to be the major releases for 0. versions, otherwise there wouldn't be a way to make incompatible releases other than going straight to 1.0. (docs)
In fact, strictly speaking even this is different to what semver really is:
Major version zero (0.y.z) is for initial development. Anything may change at any time. The public API should not be considered stable.
I.e. 0.3.1 is "meant" to be not compatible with 0.3.2, although I prefer our scheme.
There was a problem hiding this comment.
Gotcha. Ouch :/ well, i'll write a patch for this later today, since this PR was merged. Thanks you two!
This also made me realize that I wasn't using the correct term,
'associated functions', rather than 'static methods'. So I corrected
that in the method syntax chapter.