Uh oh!
There was an error while loading. Please reload this page.
std: Cleanup the sys module a bit - #25136
Merged
Merged
Conversation
alexcrichton
commented
May 5, 2015
MemberAuthor
r? @aturon |
rust-highfive
commented
May 5, 2015
Contributor
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
bors
commented
May 7, 2015
Collaborator
☔ The latest upstream changes (presumably #25175) made this pull request unmergeable. Please resolve the merge conflicts. |
aturon
commented
May 7, 2015
Contributor
Great PR. r=me after a rebase. |
Now that `std::old_io` has been removed for quite some time the naming real estate here has opened up to allow these modules to move back to their proper names.
This module has been removed for quite some time!
Perform unsafe initialization up front and then only afterward the mutex is in place do we initialize it.
alexcrichton
commented
May 7, 2015
MemberAuthor
bors added a commit
that referenced
this pull request
May 8, 2015
* Remove the 2-suffix from some modules * Remove some unused files * Remove double-boxing for `ReentrantMutex`
bors
commented
May 8, 2015
Collaborator
tshepang
commented
May 8, 2015
Member
Wow, 8 hours testing! How is this happening? |
alexcrichton
commented
May 8, 2015
MemberAuthor
Looks like @bors got confused when testing this as some windows slaves were lost. It passed one of the windows slaves, however, so I'm going to assume that this would have passed the others as well, and as a result I'm going to merge this manually. |
This was referenced May 8, 2015
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReentrantMutex