Skip to content

Correct initial guessing game example. Fixes #25147. r? @steveklabnik - #25148

Merged
bors merged 1 commit into
rust-lang:masterfrom
banks:master
May 7, 2015
Merged

Correct initial guessing game example. Fixes #25147. r? @steveklabnik#25148
bors merged 1 commit into
rust-lang:masterfrom
banks:master

Conversation

@banks

@banksbanks commented May 6, 2015

Copy link
Copy Markdown
Contributor

Let me know if I didn't follow correct procedure - seems a trivial change and no one that can be automatically tested.

@rust-highfive

rust-highfive commented May 6, 2015

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @huonw (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@steveklabnik

steveklabnik commented May 6, 2015

Copy link
Copy Markdown
Contributor

@bors: r+ rollup

@bors

bors commented May 6, 2015

Copy link
Copy Markdown
Collaborator

📌 Commit 81b90bd has been approved by steveklabnik

@steveklabnik

steveklabnik commented May 6, 2015

Copy link
Copy Markdown
Contributor

Ah yes! I was adapting the old code, and missed this one. Thanks so much!

@banksbanks mentioned this pull request May 6, 2015
Closed
@killercupkillercup mentioned this pull request May 6, 2015
Closed
rydotyosh added a commit to rydotyosh/rust that referenced this pull request May 6, 2015
@rydotyosh
doc: Fix remove unused variable
08923fb
This commit depends on rust-lang#25148.
@rydotyoshrydotyosh mentioned this pull request May 6, 2015
Merged
@jonboiserjonboiser mentioned this pull request May 7, 2015
Closed
steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 7, 2015
@steveklabnik
Rollup merge ofrust-lang#25148- banks:master, r=steveklabnik
54eb0aa
Let me know if I didn't follow correct procedure - seems a trivial change and no one that can be automatically tested.
steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 7, 2015
@steveklabnik
Rollup merge ofrust-lang#25154- rydotyosh:patch-3, r=steveklabnik
26ff571
Edit version of rust-lang#25150.
This commit depends on rust-lang#25148.
@steveklabniksteveklabnik mentioned this pull request May 7, 2015
Closed
steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 7, 2015
@steveklabnik
Rollup merge ofrust-lang#25148- banks:master, r=steveklabnik
414e37f
Let me know if I didn't follow correct procedure - seems a trivial change and no one that can be automatically tested.
steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 7, 2015
@steveklabnik
Rollup merge ofrust-lang#25154- rydotyosh:patch-3, r=steveklabnik
6db57a2
Edit version of rust-lang#25150.
This commit depends on rust-lang#25148.
@steveklabniksteveklabnik mentioned this pull request May 7, 2015
Merged
bors added a commit that referenced this pull request May 7, 2015
@bors
Auto merge of#25175- steveklabnik:rollup, r=steveklabnik
acb3aa0
- Successful merges: #24576, #24966, #25052, #25131, #25137, #25138, #25139, #25141, #25142, #25144, #25146, #25148, #25154, #25156, #25160, #25173
- Failed merges:
@bors
bors merged commit 81b90bd into rust-lang:masterMay 7, 2015
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@huonwhuonw

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@banks@rust-highfive@steveklabnik@bors@huonw