1.0 release notes and authors updates by brson · Pull Request #25196 · rust-lang/rust

brson · 2015-05-07T23:25:18Z

cc @aturon

rust-highfive · 2015-05-07T23:25:29Z

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

bluss · 2015-05-07T23:51:46Z

thread::scoped is not in 1.0

Thanks, fixed.

cjwelborn · 2015-05-08T01:04:06Z

I noticed at least one duplicate in the AUTHORS. There may be others:

GlacJAY <glacjay@gmail.com>
...
Jay True <glacjay@gmail.com>

nham · 2015-05-08T01:18:32Z

I'm in the list twice:

Nick Hamann <nick@wabbo.org>
nham <hamann.nick@gmail.com>

You can remove the second one if you'd like.

cjwelborn · 2015-05-08T01:25:51Z

There are 2 duplicated names (Alfie John and Jakub Wieczorek with different email addresses). I don't know if it's intentional or not, so I haven't tried to make a PR or anything. I found 23 duplicate email addresses (names are different, some use their middle name, some are 'handles').

cjwelborn · 2015-05-08T01:47:08Z

@brson, I made a PR on your repo that removes the duplicates in what I think is a sane way to go about it.

brson · 2015-05-08T01:48:15Z

@cjwelborn Thanks! Merged.

brson · 2015-05-08T01:51:03Z

@tshepang Under the normal release schedule, the beta of 4 weeks ago would not have its own release notes - those would be the release notes of the next stable release. So the thinking was to combine them to provide the full picture of what happened recently. The amount of new work that went into 1.0 this cycle was actually pretty small...

Beta's are not 'releases' even though we treated the last one as such.

alfiedotwtf · 2015-05-08T02:08:28Z

Looks like I'm in there twice. Thanks @cjwelborn, but my preferred email for all things Rust is alfie@alfie.wtf :)

cjwelborn · 2015-05-08T02:23:30Z

@alfiedotwtf, sorry about that. I'm glad you caught it before it was finalized.

daramos · 2015-05-08T02:35:55Z

D'oh! Looks like I had my email as my name in gitconfig.

Any chance dan@daramos.com <dan@daramos.com> could be changed to Daniel Ramos <dan@daramos.com>?

Sorry about that...

caipre · 2015-05-08T02:37:58Z

If you're taking these last minute comments... s/caipre/Nick Platt

sanxiyn · 2015-05-08T03:16:43Z

This seems to be a duplicate.

rpjohnst · 2015-05-08T03:38:39Z

Could you update "Russell rpjohnst@gmail.com" to "Russell Johnston rpjohnst@gmail.com"?

Zoxc · 2015-05-08T03:53:19Z

Can someone move John Kleint out of my names?

sfackler · 2015-05-08T04:20:09Z

The 2 appears to be missing.

ogham · 2015-05-08T04:21:14Z

Not sure why I decided to abbreviate my name. Could you change 'Ben S' to 'Ben Sago'? Ta

thorncp · 2015-05-08T04:35:54Z

Please change Chris Thorn <thorn@thoughtbot.com> to Chris Thorn <chris@thorn.co>.

So much thanks to the Rust team for doing this! 💗

sfackler · 2015-05-08T04:53:29Z

@ogham "Ben S" is the name associated with your github profile: https://github.com/ogham

laumann · 2015-05-08T05:07:35Z

@brson Is it any kind of code contribution that counts (ie commits in master)?

TyOverby · 2015-05-08T05:38:19Z

Could you change "TyOverby" to "Ty Overby"? Thanks!

huonw · 2015-05-08T05:44:24Z

@laumann yes, any commit!

blackbeam · 2015-05-08T05:46:15Z

Could you please change "blackbeam" to "Anatoly Ikorsky"?

laumann · 2015-05-08T06:02:07Z

@huonw Awesome, then I'm missing from the list (see d14109e):
Thomas Bracht Laumann Jespersen <laumann.thomas@gmail.com>.

huonw · 2015-05-08T06:04:25Z

@laumann, oh, I apologise because I realise I may have misspoke: this is the first release where the release isn't from the master branch, so some recent contributions may not be in it (I'm unsure if that commit is).

brson · 2015-05-11T01:29:08Z

@laumann Anybody with commits to this repo.

brson · 2015-05-11T01:45:57Z

Updated with all comments addressed (I think) except @Zoxc's.

bluss · 2015-05-11T01:50:56Z

, which made possible is a half sentence hanging here.

Zoxc · 2015-05-11T03:54:50Z

@brson My complaint was addressed atleast. I'm no longer listed twice.

tshepang · 2015-05-11T05:27:56Z

am curious why remove change count

Thanks for mentioning me!
This is me:
Heejong Ahn <heejongahn@gmail.com poga.bahamut@gmail.com>
p.s) To be frank, it's my first (and misc) open-source contribution and I
don't know what's really going on here so I just mocked what Poga's mail..
Plz let me know if I've done anything wrong.
2015-05-11 14:28 GMT+09:00 Tshepang Lekhonkhobe notifications@github.com:
In RELEASES.md
#25196 (comment):
@@ -1,79 +1,140 @@
-Version 1.0.0-beta (April 2015)
-* ~1100 changes, numerous bugfixes
am curious why remove change count
—
Reply to this email directly or view it on GitHub
https://github.com/rust-lang/rust/pull/25196/files#r30013677.

@brson I see you put the count back in 94caeb3... kool.

gareins · 2015-05-11T09:09:23Z

I am:
Ožbolt Menegatti <ozbolt.menegatti@gmail.com>

If it needs to be ascii, just use 'z' instead of 'ž'.

ps. Thanks everyone for an awesome language :)

jest · 2015-05-11T11:30:33Z

If spellchecking is considered relevant contribution, please add

Przemek Wesołek <jest@go.art.pl>

due to #24812

KokaKiwi · 2015-05-11T12:57:51Z

If writing a postponed RFC is considered as a relevant contribution (maybe not, but I wanted to ask anyway :p), is it possible to add

KokaKiwi <kokakiwi+rust@kokakiwi.net>

Due to rust-lang/rfcs#257

alexcrichton · 2015-05-11T17:43:07Z

r=me whenever this is ready @brson

brson · 2015-05-11T17:59:56Z

@bors: r=alexcrichton

bors · 2015-05-11T17:59:58Z

📌 Commit 94caeb3 has been approved by alexcrichton

bors · 2015-05-11T18:13:12Z

⌛ Testing commit 94caeb3 with merge a90dd32...

@aturon

cc @aturon

brson · 2015-05-11T18:18:41Z

I've already picked this into beta, so setting tag to beta-accepted

bors · 2015-05-11T20:02:16Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt

dhardy · 2015-05-16T08:46:21Z

I checked the authors file. It contains an old spam-infested email address, which is fine. Now somehow my github email appears in the 1.0 announcement, and right on queue I get a bunch of phishing emails. How'd that happen? I'm now going to have to replace the github email... don't put the new one in blog posts please.

alfiedotwtf · 2015-05-16T09:55:17Z

@dhardy that's security through obscurity. All it takes is a bot to clone one of your repo to see your email address. Consider using temporary aliases for anything public facing.

dhardy · 2015-05-16T10:06:36Z

Consider using temporary aliases for anything public facing.

That's precisely what it is, and mostly my system works (it seems bots are not in the habit of cloning repos). I only get spam on the gmail address and if anyone emails me there, they get an "out-of-office" reply notifying them that I don't read it frequently.

brson added the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 7, 2015

rust-highfive assigned nikomatsakis May 7, 2015

bluss reviewed May 7, 2015
View reviewed changes

alfiedotwtf mentioned this pull request May 8, 2015
Switching to preferred email brson/rust#28
Merged

sanxiyn reviewed May 8, 2015
View reviewed changes

Comment threadRELEASES.md Outdated
sanxiynMay 8, 2015
Copy link
Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be a duplicate.

sfackler reviewed May 8, 2015
View reviewed changes

brson force-pushed the relnotes branch 4 times, most recently from 851ade0 to 5c26a7bCompare May 11, 2015 01:45

brson force-pushed the relnotes branch from 5c26a7b to b9506b7Compare May 11, 2015 01:46

bluss reviewed May 11, 2015
View reviewed changes

Update AUTHORS.txt and RELEASES.md for 1.0
847c088

brson force-pushed the relnotes branch from b9506b7 to 847c088Compare May 11, 2015 01:52

brson mentioned this pull request May 11, 2015
Update AUTHORS.txt and RELEASES.md for 1.0 (beta) #25294
Merged

tshepang reviewed May 11, 2015
View reviewed changes

More authors updates
94caeb3

bors added a commit that referenced this pull request May 11, 2015
Auto merge of#25196- brson:relnotes, r=alexcrichton
a90dd32
cc @aturon

brson added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels May 11, 2015

bors merged commit 94caeb3 into rust-lang:masterMay 11, 2015

Uh oh!

Uh oh!

Conversation

brson commented May 7, 2015

Uh oh!

rust-highfive commented May 7, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjwelborn commented May 8, 2015

Uh oh!

nham commented May 8, 2015

Uh oh!

cjwelborn commented May 8, 2015

Uh oh!

cjwelborn commented May 8, 2015

Uh oh!

brson commented May 8, 2015

Uh oh!

brson commented May 8, 2015

Uh oh!

alfiedotwtf commented May 8, 2015

Uh oh!

cjwelborn commented May 8, 2015

Uh oh!

daramos commented May 8, 2015

Uh oh!

caipre commented May 8, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rpjohnst commented May 8, 2015

Uh oh!

Zoxc commented May 8, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ogham commented May 8, 2015

Uh oh!

thorncp commented May 8, 2015

Uh oh!

sfackler commented May 8, 2015

Uh oh!

laumann commented May 8, 2015

Uh oh!

TyOverby commented May 8, 2015

Uh oh!

huonw commented May 8, 2015

Uh oh!

blackbeam commented May 8, 2015

Uh oh!

laumann commented May 8, 2015

Uh oh!

huonw commented May 8, 2015

Uh oh!

brson commented May 11, 2015

Uh oh!

brson commented May 11, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Zoxc commented May 11, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

-Version 1.0.0-beta (April 2015)

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gareins commented May 11, 2015

Uh oh!

jest commented May 11, 2015

Uh oh!