Uh oh!
There was an error while loading. Please reload this page.
Add a precision for references issues in doc - #25222
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
needs triple ticks and text
steveklabnik
commented
May 10, 2015
Contributor
r= me after the nit |
GuillaumeGomez
commented
May 10, 2015
MemberAuthor
I saw there were also missing backticks at line 316, I added them. In this, should I squash ? |
GuillaumeGomez
commented
May 10, 2015
MemberAuthor
steveklabnik
commented
May 10, 2015
Contributor
The Anyway, I think that I have already accepted a PR to add that other missing one, but let's just let homu sort it out :) |
steveklabnik
commented
May 10, 2015
Contributor
@bors: r+ rollup |
bors
commented
May 10, 2015
Collaborator
📌 Commit 25543f3 has been approved by |
GuillaumeGomez
commented
May 10, 2015
MemberAuthor
Ok haha. I wasn't sure about the r= you, so I tried :p |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @steveklabnik