Uh oh!
There was an error while loading. Please reload this page.
Remove extra parentheses - #25282
Merged
Merged
Conversation
rust-highfive
commented
May 10, 2015
Contributor
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @huonw (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
badboy
commented
May 10, 2015
MemberAuthor
yeah, great. A typo in the commit message -_- edit: Force-pushed before anyone saw it ;) |
alexcrichton
commented
May 11, 2015
Member
steveklabnik added a commit
to steveklabnik/rust
that referenced
this pull request
May 11, 2015
…chton As mentioned in rust-lang#16676 (comment) this makes it a little bit more correct. I'm a bit unsure whether or not it should be explained that the transcriber can be wrapped in parentheses or curly braces if necessary.
steveklabnik added a commit
to steveklabnik/rust
that referenced
this pull request
May 12, 2015
…chton As mentioned in rust-lang#16676 (comment) this makes it a little bit more correct. I'm a bit unsure whether or not it should be explained that the transcriber can be wrapped in parentheses or curly braces if necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #16676 (comment) this makes it a little bit more correct.
I'm a bit unsure whether or not it should be explained that the transcriber can be wrapped in parentheses or curly braces if necessary.