Uh oh!
There was an error while loading. Please reload this page.
Record correct span for static mut items in trans/save - #25333
Conversation
rust-highfive
commented
May 12, 2015
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
nrc
commented
May 13, 2015
@bors r+ rollup |
bors
commented
May 13, 2015
📌 Commit 46753da has been approved by |
As it is, save-analysis appears to return the span for the 'mut' in a declaration 'static mut identifier...' instead of the identifier. This minor change appears to fix the problem, by skipping the mut when it is present.
steveklabnik
commented
May 13, 2015
@bors: rollup- |
steveklabnik
commented
May 13, 2015
sorry, kicking everything non-docs out of the rollup for now so i can go to sleep |
bors
commented
May 13, 2015
⌛ Testing commit 46753da with merge af41097... |
As it is, save-analysis appears to return the span for the 'mut' in a declaration 'static mut identifier...' instead of the identifier. This minor change appears to fix the problem, by skipping the mut when it is present.
As it is, save-analysis appears to return the span for the 'mut' in a declaration 'static mut identifier...' instead of the identifier. This minor change appears to fix the problem, by skipping the mut when it is present.