Uh oh!
There was an error while loading. Please reload this page.
TRPL: embedding rust - #25341
Conversation
rust-highfive
commented
May 12, 2015
(rust_highfive has picked a reviewer for you, use r? to override) |
steveklabnik
commented
May 12, 2015
This is based off of work by both @alexcrichton and @callahad. ❤️ |
There was a problem hiding this comment.
Unless optimiser optimises this away?
There was a problem hiding this comment.
Yeah, I had to be careful to use a debug build of my "spin uselessly" library, lest nothing happened at all. :)
There was a problem hiding this comment.
I added a let _ = x line, and performance didn't seem to change. is the optimizer smart enough in these cases?
steveklabnik
commented
May 12, 2015
Added python and node. So easy! |
steveklabnik
commented
May 12, 2015
more nits addressed. r? @alexcrichton |
alexcrichton
commented
May 12, 2015
Just a few minor nits here and there, but otherwise r=me, thanks @steveklabnik! |
steveklabnik
commented
May 12, 2015
@bors: r=alexcrichton rollup |
bors
commented
May 12, 2015
📌 Commit fc6372e has been approved by |
This is the first chunk of the last guide I'll land before 1.0. I wanted to kick off reviews earlier rahter than later, so here's the important parts, with the Python and Node implementations coming later today.