Uh oh!
There was an error while loading. Please reload this page.
Abstract over the file loading mechanism in libsyntax's Parser. - #25387
Merged
Conversation
rust-highfive
commented
May 13, 2015
Contributor
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
eddyb
commented
May 14, 2015
ContributorAuthor
cc @nikomatsakis This is the custom file-loading API I was telling you about. |
nikomatsakis
commented
May 16, 2015
Contributor
@bors r+ lgtm |
bors
commented
May 16, 2015
Collaborator
📌 Commit 07d4f77 has been approved by |
bors
commented
May 16, 2015
Collaborator
⌛ Testing commit 07d4f77 with merge f171456... |
bors
commented
May 16, 2015
Collaborator
💔 Test failed - auto-mac-64-opt |
eddyb
commented
May 16, 2015
ContributorAuthor
My bad, I've missed the error message change for loading non-UTF8 files. |
eddyb
commented
May 16, 2015
ContributorAuthor
@bors r=nikomatsakis |
bors
commented
May 16, 2015
Collaborator
📌 Commit 8cc9878 has been approved by |
bors added a commit
that referenced
this pull request
May 17, 2015
This allows compiling entire crates from memory or preprocessing source files before they are tokenized.
Minor API refactoring included, which is a [breaking-change] for libsyntax users:
* `ParseSess::{next_node_id, reserve_node_ids}` moved to rustc's `Session`
* `new_parse_sess` -> `ParseSess::new`
* `new_parse_sess_special_handler` -> `ParseSess::with_span_handler`
* `mk_span_handler` -> `SpanHandler::new`
* `default_handler` -> `Handler::new`
* `mk_handler` -> `Handler::with_emitter`
* `string_to_filemap(sess source, path)` -> `sess.codemap().new_filemap(path, source)`bors
commented
May 17, 2015
Collaborator
bors
commented
May 17, 2015
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows compiling entire crates from memory or preprocessing source files before they are tokenized.
Minor API refactoring included, which is a [breaking-change] for libsyntax users:
ParseSess::{next_node_id, reserve_node_ids}moved to rustc'sSessionnew_parse_sess->ParseSess::newnew_parse_sess_special_handler->ParseSess::with_span_handlermk_span_handler->SpanHandler::newdefault_handler->Handler::newmk_handler->Handler::with_emitterstring_to_filemap(sess source, path)->sess.codemap().new_filemap(path, source)