Uh oh!
There was an error while loading. Please reload this page.
Fix panic in lint for out of range literals - #25612
Merged
Merged
Conversation
rust-highfive
commented
May 19, 2015
Contributor
r? @nrc (rust_highfive has picked a reviewer for you, use r? to override) |
alexcrichton
commented
May 19, 2015
Member
bors
commented
May 19, 2015
Collaborator
☔ The latest upstream changes (presumably #24333) made this pull request unmergeable. Please resolve the merge conflicts. |
petrochenkov
commented
May 20, 2015
ContributorAuthor
Rebased |
nrc
commented
May 20, 2015
Member
bors
commented
May 20, 2015
Collaborator
📌 Commit 7b1916d has been approved by |
bors
commented
May 21, 2015
Collaborator
bors added a commit
that referenced
this pull request
May 21, 2015
bors
commented
May 21, 2015
Collaborator
bors added a commit
that referenced
this pull request
May 26, 2015
A regression was introduced by commit 7b1916d#25612. Negative signed integer literals less than -9223372036854775808i64 were no longer properly reported as #[warn(overflowing_literals)]. Also adding missing test cases to test/compile-fail/lint-type-overflow.rs which could have detected the regression. Further explanation: The expression `(negative && v > max as u64 + 1)` relies on the fact that algebraically speaking `-min == max + 1` to avoid negation and removing the need for `min` completely. If i128 or i256 are ever added, it should also work for these types without requiring a change to `min != i64::MIN &&` also simplifying maintenance. r? @pnkfelix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported here #25441 (comment)