Uh oh!
There was an error while loading. Please reload this page.
mk: Ensure LINK_$(1) is defined for all targets - #25799
Merged
Merged
Conversation
alexcrichton
commented
May 26, 2015
MemberAuthor
r? @pnkfelix |
rust-highfive
commented
May 26, 2015
Contributor
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
The changes scaled back in 4cc025d were a little too aggressive and broke a bunch of cross compilations by not defining the `LINK_$(1)` variable for all targets. This commit ensures that the variable is defined for all targets by defaulting it to the normal compiler if it's not already defined (it's only defined specially for MSVC). Closesrust-lang#25723
luqmana
commented
May 26, 2015
Contributor
@bors: r+ |
bors
commented
May 26, 2015
Collaborator
📌 Commit bc7c62d has been approved by |
bors
commented
May 27, 2015
Collaborator
bors added a commit
that referenced
this pull request
May 27, 2015
The changes scaled back in 4cc025d were a little too aggressive and broke a bunch of cross compilations by not defining the `LINK_$(1)` variable for all targets. This commit ensures that the variable is defined for all targets by defaulting it to the normal compiler if it's not already defined (it's only defined specially for MSVC). Closes#25723
bors
commented
May 27, 2015
Collaborator
💔 Test failed - auto-win-gnu-64-opt |
alexcrichton
commented
May 27, 2015
MemberAuthor
@bors: retry On Wed, May 27, 2015 at 8:02 AM, bors notifications@github.com wrote:
|
bors added a commit
that referenced
this pull request
May 27, 2015
The changes scaled back in 4cc025d were a little too aggressive and broke a bunch of cross compilations by not defining the `LINK_$(1)` variable for all targets. This commit ensures that the variable is defined for all targets by defaulting it to the normal compiler if it's not already defined (it's only defined specially for MSVC). Closes#25723Closes#25802
bors
commented
May 27, 2015
Collaborator
bors
commented
May 27, 2015
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes scaled back in 4cc025d were a little too aggressive and broke a
bunch of cross compilations by not defining the
LINK_$(1)variable for alltargets. This commit ensures that the variable is defined for all targets by
defaulting it to the normal compiler if it's not already defined (it's only
defined specially for MSVC).
Closes#25723
Closes#25802