Skip to content

properly null out ptr in LinkedList::split_off - fixes #26021 - #26022

Merged
bors merged 1 commit into
rust-lang:masterfrom
Gankra:fix-linked-list
Jun 5, 2015
Merged

properly null out ptr in LinkedList::split_off - fixes #26021#26022
bors merged 1 commit into
rust-lang:masterfrom
Gankra:fix-linked-list

Conversation

@Gankra

@GankraGankra commented Jun 5, 2015

Copy link
Copy Markdown
Contributor

Still running tests...

@rust-highfive

rust-highfive commented Jun 5, 2015

Copy link
Copy Markdown
Contributor

r? @huonw

(rust_highfive has picked a reviewer for you, use r? to override)

huonw
huonw reviewed Jun 5, 2015
View reviewed changes
Comment threadsrc/libcollections/linked_list.rs Outdated

@huonwhuonwJun 5, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a brief comment?

@GankraGankraJun 5, 2015

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you have in mind?

@huonw

huonw commented Jun 5, 2015

Copy link
Copy Markdown
Contributor

r=me with the comment

@Gankra

Gankra commented Jun 5, 2015

Copy link
Copy Markdown
ContributorAuthor

@bors r=huonw p=1

@bors

bors commented Jun 5, 2015

Copy link
Copy Markdown
Collaborator

📌 Commit e12d386 has been approved by huonw

bors added a commit that referenced this pull request Jun 5, 2015
@bors
Auto merge of#26022- Gankro:fix-linked-list, r=huonw
da0d452
Still running tests...
@bors

bors commented Jun 5, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit e12d386 with merge da0d452...

@alexcrichtonalexcrichton added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 5, 2015
@Gankra

Gankra commented Jun 5, 2015

Copy link
Copy Markdown
ContributorAuthor

whoops, the issue number is wrong.

@Gankra

Gankra commented Jun 5, 2015

Copy link
Copy Markdown
ContributorAuthor

Actually fixes #26021 ...

@bors

bors commented Jun 5, 2015

Copy link
Copy Markdown
Collaborator

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt

@bors
bors merged commit e12d386 into rust-lang:masterJun 5, 2015
@bluss

bluss commented Jun 5, 2015

Copy link
Copy Markdown
Contributor

Great!

@aturonaturon added the T-libs-api [DEPRECATED; DO NOT USE] label Jun 9, 2015
@alexcrichton

alexcrichton commented Jun 9, 2015

Copy link
Copy Markdown
Member

triage: beta-accepted

@alexcrichtonalexcrichton added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jun 9, 2015
@alexcrichtonalexcrichton mentioned this pull request Jun 10, 2015
Merged
@alexcrichtonalexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 11, 2015
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@huonwhuonw

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Gankra@rust-highfive@huonw@bors@bluss@alexcrichton@aturon