Uh oh!
There was an error while loading. Please reload this page.
Clarify the usage of "hints" in const_eval. - #26683
Conversation
rust-highfive
commented
Jun 30, 2015
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
c05e030 to
a745d0cComparebors
commented
Jul 6, 2015
☔ The latest upstream changes (presumably #26757) made this pull request unmergeable. Please resolve the merge conflicts. |
huonw
commented
Jul 8, 2015
r? @pnkfelix (random person from the compiler subteam) |
There was a problem hiding this comment.
(It took me a little while to convince myself that this ends up being equivalent to the effect we were getting before via the get_substs parameter, but I now believe the tables in the tcx should match even in the case where check::_match::check_pat was passing in a closure that calls fcx.item_substs(), so this should be okay.)
pnkfelix
commented
Jul 17, 2015
@eefriedman I'm basically all in favor of this PR. I've put some feedback up above but you can treat it as an r=me after a rebase. |
The "hint" mechanism is essentially used as a workaround to compute types for expressions which have not yet been type-checked. This commit clarifies that usage, and limits the effects to the places where it is currently necessary. Fixesrust-lang#26210.
eefriedman
commented
Jul 18, 2015
Rebased. |
oli-obk
commented
Jul 22, 2015
ping @pnkfelix |
pnkfelix
commented
Jul 22, 2015
@bors r+ |
bors
commented
Jul 22, 2015
📌 Commit 6bdfb05 has been approved by |
bors
commented
Jul 22, 2015
The "hint" mechanism is essentially used as a workaround to compute types for expressions which have not yet been type-checked. This commit clarifies that usage, and limits the effects to the places where it is currently necessary. Fixes#26210.
The "hint" mechanism is essentially used as a workaround to compute
types for expressions which have not yet been type-checked. This
commit clarifies that usage, and limits the effects to the places
where it is currently necessary.
Fixes#26210.