Guidance on Windows install re "Add to PATH"

[Dangthrimble]

Updated "Installing Rust" and "After installation" to provide additional guidance to Windows users on including Rust in the Path system variable.

r? @steveklabnik

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[steveklabnik]

Shouldn't this be %PATH% or something?

[Dangthrimble]

Happy for it to be %PATH%.

----- Original Message -----
From: "rust-lang/rust"
To:"rust-lang/rust"
Cc:"Jonathan Hansford"
Sent:Tue, 21 Jul 2015 08:52:27 -0700
Subject:Re: [rust] Guidance on Windows install re "Add to PATH"
(#27183)

In src/doc/trpl/installing-rust.md [1]: > @@ -25,6 +25,12 @@ $ sh rustup.sh > [insecurity]:

http://curlpipesh.tumblr.com > > If you're on Windows, please download
the appropriate [installer][install-page]. > +NOTE: By default,
the Windows installer will not add Rust to the Path system

Shouldn't this be %PATH% or something? —

Reply to this email directly or view it on GitHub [2].

Links:

[1] #27183 (comment)
[2] https://github.com/rust-lang/rust/pull/27183/files#r35118694

[steveklabnik]

One small formatting nit, but otherwise, looks great 👍

[Dangthrimble]

Steve,
On the next page, "Hello, world!", it states "Rust is an ‘expression
oriented’ language" without explaining what that means. There is a
Wikipedia page on Expression-oriented programming language [1].
Would it be worth adding a link to that or some other page to provide
some context?
Jonathan

----- Original Message -----
From: "rust-lang/rust"
To:"rust-lang/rust"
Cc:"Jonathan Hansford"
Sent:Tue, 21 Jul 2015 08:52:55 -0700
Subject:Re: [rust] Guidance on Windows install re "Add to PATH"
(#27183)

One small formatting nit, but otherwise, looks great —

Reply to this email directly or view it on GitHub [2].

Links:

[1]
https://en.wikipedia.org/wiki/Expression-oriented_programming_language
[2]
#27183 (comment)

[steveklabnik]

@Dangthrimble , we prefer to use our own http://doc.rust-lang.org/stable/book/glossary.html rather than link to wikipedia, as one of the main uses of rust's docs is offline, where external links don't work. we also don't control the quality of content on wikipedia.

I would prefer just updating this PR to fix the %PATH thing, and then making another with that, if you don't mind :)

[Dangthrimble]

@steveklabnik

I presume you would like me to fix %PATH%. I'll get onto it as soon as I have a spare moment.

I'm working my way through The Book (slowly!) and am happy to separately offer up changes as I work through for you to consider. Is it OK if I update the glossary as well?

[steveklabnik]

Yup! Whenever you have the chance, no rush. Same with the glossary, I would love to see it significantly expanded. :)

[Dangthrimble]

Path now updated to %PATH%.

[steveklabnik]

@bors: r+ rollup

[steveklabnik]

Thank you!

[bors]

📌 Commit f2c7345 has been approved by steveklabnik