Skip to content

Gate associated type defaults - #27382

Merged
bors merged 3 commits into
rust-lang:masterfrom
brson:gate-assoc-type
Jul 31, 2015
Merged

Gate associated type defaults#27382
bors merged 3 commits into
rust-lang:masterfrom
brson:gate-assoc-type

Conversation

@brson

@brsonbrson commented Jul 29, 2015

Copy link
Copy Markdown
Contributor

There are still problems in both the design and implementation of this, so we don't want it landing in 1.2.

cc @arielb1@nikomatsakis

cc #27364

r? @alexcrichton

@brsonbrson added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 29, 2015
@brson

brson commented Jul 29, 2015

Copy link
Copy Markdown
ContributorAuthor

Hm, this doesn't actually work locally. Still testing.

@brson

brson commented Jul 29, 2015

Copy link
Copy Markdown
ContributorAuthor

OK, this is ready to go. I'd like to get this backported and I'll crater test on the beta branch.

@brson

brson commented Jul 29, 2015

Copy link
Copy Markdown
ContributorAuthor

r? @alexcrichton

@brsonbrson mentioned this pull request Jul 29, 2015
Merged
@brson

brson commented Jul 29, 2015

Copy link
Copy Markdown
ContributorAuthor

Running through crater.

@brson
Feature gate associated type defaults
a09bce1
There are multiple issues with them as designed and implemented.
cc rust-lang#27364
@brson

brson commented Jul 30, 2015

Copy link
Copy Markdown
ContributorAuthor

4 regressions. No non-root regressions.

@brson

brson commented Jul 30, 2015

Copy link
Copy Markdown
ContributorAuthor

Those regressions are either for non-stable-compatible crates or those crates are not using the defaults.

@brsonbrson added regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. relnotes Marks issues that should be documented in the release notes of the next release. beta-nominated Nominated for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Jul 30, 2015
@brson

brson commented Jul 30, 2015

Copy link
Copy Markdown
ContributorAuthor

@aturon is satisfied with this breakage. @bors r+

@bors

bors commented Jul 30, 2015

Copy link
Copy Markdown
Collaborator

📌 Commit a09bce1 has been approved by brson

@brsonbrson added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jul 30, 2015
@brson

brson commented Jul 30, 2015

Copy link
Copy Markdown
ContributorAuthor

@bors r=aturon

@bors

bors commented Jul 30, 2015

Copy link
Copy Markdown
Collaborator

📌 Commit a09bce1 has been approved by brson

@brsonbrson removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 30, 2015
@bors

bors commented Jul 30, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit a09bce1 with merge d5fc0da...

@bors

bors commented Jul 30, 2015

Copy link
Copy Markdown
Collaborator

💔 Test failed - auto-mac-64-opt

@brson

brson commented Jul 30, 2015

Copy link
Copy Markdown
ContributorAuthor

@bors r=alexcrichton

@bors

bors commented Jul 30, 2015

Copy link
Copy Markdown
Collaborator

📌 Commit 4aaf1be has been approved by alexcrichton

bors added a commit that referenced this pull request Jul 31, 2015
@bors
Auto merge of#27382- brson:gate-assoc-type, r=alexcrichton
8d2eb59
There are still problems in both the design and implementation of this, so we don't want it landing in 1.2.
cc @arielb1@nikomatsakis cc #27364
r? @alexcrichton
@bors

bors commented Jul 31, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 4aaf1be with merge 8d2eb59...

@bors

bors commented Jul 31, 2015

Copy link
Copy Markdown
Collaborator

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

@bors
bors merged commit 4aaf1be into rust-lang:masterJul 31, 2015
This was referenced Jul 31, 2015
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexcrichtonalexcrichton

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.regression-from-stable-to-nightlyPerformance or correctness regression from stable to nightly.relnotesMarks issues that should be documented in the release notes of the next release.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brson@bors@alexcrichton