Uh oh!
There was an error while loading. Please reload this page.
Smaller refactor svh - #27461
Conversation
46a313e to
cc3ebbbCompareThis makes the hash of a crate no longer whitespace dependant on it's attributes Ping rust-lang#14132
cc3ebbb to
de81de5Comparericho
commented
Aug 1, 2015
(The assertion that this closes #14132 was based on yolo-science™, updated to reflect that) |
brson
commented
Aug 2, 2015
@bors r+ Nice improvements. |
bors
commented
Aug 2, 2015
📌 Commit de81de5 has been approved by |
richo
commented
Aug 2, 2015
@brson you'll need to r-, I ran make check overnight and it breaks some svh tests (in the same way that my other changes did, it's upset about the crates hashes changing) |
Gankra
commented
Aug 2, 2015
@bors r- On Sun, Aug 2, 2015 at 11:54 AM, Richo Healey notifications@github.com
|
alexcrichton
commented
Sep 28, 2015
Closing due to inactivity, but feel free to send a new PR with tests fixed! |
This is the first half of the implementation of what I set out to do in #26629.
This will make the location of attrs in crates not affect their hash values any more, although it doesn't expose a public way to do this outside of an entire Svh yet, which is how I intended to implement the dupe attribute lint.
For posterity, I did the yolo science with: https://gist.github.com/richo/f750855a762804e2b3e9
r? @alexcrichton
Ping #14132