Uh oh!
There was an error while loading. Please reload this page.
some more clippy-based improvements - #28287
Merged
Merged
Conversation
llogiq
commented
Sep 7, 2015
ContributorAuthor
I didn't do all the elision things yet. We can wrap them up in the next PR. |
I'd have thought that the types of the slice::Split would have been inferred, but this appears not to be the case. Reverted this one change.
llogiq
commented
Sep 8, 2015
ContributorAuthor
@Manishearth r? I may add more stuff in later PRs. |
Manishearth
commented
Sep 8, 2015
Member
@bors r+ rollup |
bors
commented
Sep 8, 2015
Collaborator
📌 Commit d956e63 has been approved by |
bors
commented
Sep 8, 2015
Collaborator
⌛ Testing commit d956e63 with merge b2b6c6b... |
bors added a commit
that referenced
this pull request
Sep 8, 2015
It's a large number of small improvements to the code, mostly readability-related, but removing closures and replacing `str::to_string()` with `.to_owned()` should also positively affect performance. r? @Manishearth (once it compiles, of course 😄)
bors
commented
Sep 8, 2015
Collaborator
llogiq
commented
Sep 8, 2015
ContributorAuthor
Yay! 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a large number of small improvements to the code, mostly readability-related, but removing closures and replacing
str::to_string()with.to_owned()should also positively affect performance.r? @Manishearth (once it compiles, of course 😄)