Skip to content

Make a lexer error message friendlier - #283

Closed
catamorphism wants to merge 4 commits into
rust-lang:masterfrom
catamorphism:master
Closed

Make a lexer error message friendlier#283
catamorphism wants to merge 4 commits into
rust-lang:masterfrom
catamorphism:master

Conversation

@catamorphism

Copy link
Copy Markdown
Contributor

I know you said not to change rustboot, but I spent a bunch of time trying to track down this error given the unfriendly error message from before, so I thought this was worth committing.

I don't know why github included a bunch of other commits in this, but the change to lexer.mll is the only one that matters.

and literals with the 'f32' or 'f64' suffixes work as well. In
addition, logging things with the f32 or f64 type works. (float is
still assumed to be a synonym for f64).
and literals with the 'f32' or 'f64' suffixes work as well. In
addition, logging things with the f32 or f64 type works. (float is
still assumed to be a synonym for f64).
@graydon

Copy link
Copy Markdown
Contributor

Integrated.

@graydongraydon closed this Mar 24, 2011
oli-obk added a commit to oli-obk/rust that referenced this pull request Sep 19, 2017
keeperofdakeys pushed a commit to keeperofdakeys/rust that referenced this pull request Dec 12, 2017
Add notbsd process_vm_readv and process_vm_writev system calls
kazcw pushed a commit to kazcw/rust that referenced this pull request Oct 23, 2018
This commit updates to the latest nightly's syntax where `#[target_feature =
"+foo"]` is now deprecated in favor of `#[target_feature(enable = "foo")]`.
Additionally `#[target_feature]` can only be applied to `unsafe` functions for
now.
Along the way this removes a few exampels that were just left around and also
disables the `fxsr` modules as that target feature will need to land in upstream
rust-lang/rust first as it's currently unknown to the compiler.
dlrobertson pushed a commit to dlrobertson/rust that referenced this pull request Nov 29, 2018
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Oct 26, 2020
noscripter pushed a commit to noscripter/rust that referenced this pull request Sep 8, 2025
U007D pushed a commit to U007D/rust-mos that referenced this pull request Aug 21, 2026
283: Docs r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
U007D pushed a commit to U007D/rust-mos that referenced this pull request Aug 21, 2026
383: Bump failure from 0.1.3 to 0.1.4 r=DJMcNab a=dependabot[bot]
Bumps [failure](https://github.com/rust-lang-nursery/failure) from 0.1.3 to 0.1.4.
<details>
<summary>Changelog</summary>
*Sourced from [failure's changelog](https://github.com/rust-lang-nursery/failure/blob/master/RELEASES.md).*
> # Version 0.1.4
> > - Improved error reporting of the derive feature
> - Resolved a potential internal ambiguity when using the backtrace feature
> that prevented backtrace from improving an upstream API.
> - Changed the bounds on std error compat conversions through the From trait
> to take Sync and Send into account.
</details>
<details>
<summary>Commits</summary>
- [`70b98e6`](rust-lang-deprecated/failure@70b98e6) 0.1.4
- [`937fb70`](rust-lang-deprecated/failure@937fb70) Add Sync and Send as failure::Error supports them. ([rust-lang#283](https://github-redirect.dependabot.com/rust-lang-nursery/failure/issues/283))
- [`15b6798`](rust-lang-deprecated/failure@15b6798) Improving procmacro error reporting
- [`22bfd31`](rust-lang-deprecated/failure@22bfd31) support trailing commas in macros ([rust-lang#273](https://github-redirect.dependabot.com/rust-lang-nursery/failure/issues/273))
- [`26fc6eb`](rust-lang-deprecated/failure@26fc6eb) Future proof debug formatting. Fixes [rust-lang#279](https://github-redirect.dependabot.com/rust-lang-nursery/failure/issues/279)
- [`0f89723`](rust-lang-deprecated/failure@0f89723) Reformat for latest rustfmt
- [`8f8f92f`](rust-lang-deprecated/failure@8f8f92f) Update metadata to point to new docs
- See full diff in [compare view](rust-lang-deprecated/failure@0.1.3...0.1.4)
</details>
<br />
[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=failure&package-manager=cargo&previous-version=0.1.3&new-version=0.1.4)](https://dependabot.com/compatibility-score.html?dependency-name=failure&package-manager=cargo&previous-version=0.1.3&new-version=0.1.4)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme
Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)
Finally, you can contact us by mentioning @dependabot.
</details>
Co-authored-by: dependabot[bot] <support@dependabot.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@catamorphism@graydon