Skip to content

Add new error codes in librustc - #28353

Merged
bors merged 2 commits into
rust-lang:masterfrom
GuillaumeGomez:error_codes
Sep 16, 2015
Merged

Add new error codes in librustc#28353
bors merged 2 commits into
rust-lang:masterfrom
GuillaumeGomez:error_codes

Conversation

@GuillaumeGomez

@GuillaumeGomezGuillaumeGomez commented Sep 11, 2015

Copy link
Copy Markdown
Member

r? @Manishearth

This is a work in progress.

nagisa
nagisa reviewed Sep 11, 2015
View reviewed changes
Comment threadsrc/librustc/diagnostics.rs

@nagisanagisaSep 11, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can’t this be generalised to the E0452? There seems really little use to differentiate between an empty name and a malformed attribute.

@GuillaumeGomezGuillaumeGomezSep 11, 2015

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is quite hard to say... It can be generalised, but like this, we have a very precise error code for each.

@GuillaumeGomez

GuillaumeGomez commented Sep 14, 2015

Copy link
Copy Markdown
MemberAuthor

@Manishearth: I'm done for librustc. Waiting for your review.

Manishearth
Manishearth reviewed Sep 14, 2015
View reviewed changes
Comment threadsrc/librustc/diagnostics.rs Outdated

@ManishearthManishearthSep 14, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what this sentence is trying to say here

@GuillaumeGomezGuillaumeGomezSep 15, 2015

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to replace the message from the compiler when something is unstable or deprecated with the tag #[deprecated] by some kind of compilation message. But it seems it's not possible. I hope I was more clear...

@ManishearthManishearthSep 16, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"It is not possible to use stability attributes outside of the standard library. Also, for now, it is not possible to write deprecation messages either."

@GuillaumeGomez

GuillaumeGomez commented Sep 16, 2015

Copy link
Copy Markdown
MemberAuthor

Updated !

@Manishearth

Manishearth commented Sep 16, 2015

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Sep 16, 2015

Copy link
Copy Markdown
Collaborator

📌 Commit e6f6da1 has been approved by Manishearth

@bors

bors commented Sep 16, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit e6f6da1 with merge 8dfb890...

bors added a commit that referenced this pull request Sep 16, 2015
@bors
Auto merge of#28353- GuillaumeGomez:error_codes, r=Manishearth
8dfb890
r? @Manishearth This is a work in progress.
@bors

bors commented Sep 16, 2015

Copy link
Copy Markdown
Collaborator

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

@bors
bors merged commit e6f6da1 into rust-lang:masterSep 16, 2015
@borsbors mentioned this pull request Sep 16, 2015
Merged
@GuillaumeGomez
GuillaumeGomez deleted the error_codes branch September 16, 2015 10:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ManishearthManishearth

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GuillaumeGomez@Manishearth@bors@nagisa