Uh oh!
There was an error while loading. Please reload this page.
Merged
Conversation
rust-highfive
commented
Sep 20, 2015
Contributor
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
There was a problem hiding this comment.
I think this one can stay? Intention seems to be to reduce the duplication in the two cases.
Author
There was a problem hiding this comment.
I removed it because it seems impossible to do so now, you can't place a pub qualifier on a macro invocation (#22285).
Contributor
There was a problem hiding this comment.
Ok, yep, the FIXME is obsoleted now.
bluss
commented
Sep 20, 2015
Contributor
The rest looks good to me! Nice work to clean up all those small old items. |
bluss
commented
Sep 20, 2015
Contributor
a reviewer can r=me with the one inline comment addressed. |
bluss
commented
Sep 20, 2015
Contributor
@bors r+ thank you! |
bors
commented
Sep 20, 2015
Collaborator
📌 Commit 140e2d3 has been approved by |
bors
commented
Sep 20, 2015
Collaborator
bors added a commit
that referenced
this pull request
Sep 20, 2015
As the title says, just cleaning up some old stuff.
bors
commented
Sep 20, 2015
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title says, just cleaning up some old stuff.