Uh oh!
There was an error while loading. Please reload this page.
E0422 description. - #28554
Conversation
rust-highfive
commented
Sep 20, 2015
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @arielb1 (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
alexispurslane
commented
Sep 20, 2015
Thanks, @apasel422! (I also squashed the commits.) |
apasel422
commented
Sep 20, 2015
@ChristopherDumas Should this be in |
alexispurslane
commented
Sep 20, 2015
I don't know. |
apasel422
commented
Sep 20, 2015
|
alexispurslane
commented
Sep 20, 2015
Yeah, your right. |
alexispurslane
commented
Sep 20, 2015
I squashed the commits again. |
apasel422
commented
Sep 20, 2015
You'll also have to remove line 914. |
alexispurslane
commented
Sep 20, 2015
Whoops! OK. |
There was a problem hiding this comment.
You can delete it, rather than comment it out.
There was a problem hiding this comment.
OK? Is that better? I noticed that some are commented out, while some are deleted.
apasel422
commented
Sep 20, 2015
That's better. The ones that are commented out are commented out instead of deleted in order to ensure that no one uses them in the future (because they apply to errors that no longer exist). |
arielb1
commented
Oct 1, 2015
bors
commented
Oct 1, 2015
📌 Commit a818f9f has been approved by |
bors
commented
Oct 1, 2015
⌛ Testing commit a818f9f with merge 48a24bf... |
bors
commented
Oct 1, 2015
💔 Test failed - auto-win-msvc-64-opt |
alexcrichton
commented
Oct 1, 2015
@bors: retry On Thu, Oct 1, 2015 at 9:26 AM, bors notifications@github.com wrote:
|
No description provided.