Uh oh!
There was an error while loading. Please reload this page.
trpl: Refactor returning closures section - #28588
Conversation
rust-highfive
commented
Sep 22, 2015
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
There was a problem hiding this comment.
I'm a little concerned about this wording, but I can't quite articulate why. Also, why the dashes?
There was a problem hiding this comment.
I am too... 😄 Please suggest a better wording... The dashes are there so that "create an object and make it static" is taken together when applying "not possible to"..!
There was a problem hiding this comment.
Ahh, i see. Yeah, that's not exactly how dashes are usually used, they're used in place of commas or parenthesis, and you wouldn't do that with
so as to, return a static
which is why it seems awkward.
critiqjo
commented
Sep 22, 2015
How does it look now? (I'll rebase it tomorrow if it seems okay to you) |
critiqjo
commented
Sep 23, 2015
There was a mistake in the last commit, which should be fixed now... |
There was a problem hiding this comment.
Can we change this to
we cannot directly assign a
'staticlifetime to an object. So we'll
After that, this should be good to go 👍
steveklabnik
commented
Sep 24, 2015
r=me after the nit is fixed, and the commits are squashed |
critiqjo
commented
Sep 24, 2015
@bors r=steveklabnik rollup I hope rollup is the right thing to do... (been staring at that line for 5 minutes... ok let's click the green button 😅) |
steveklabnik
commented
Sep 24, 2015
@critiqjo bors only listens to those who have access, so don't worry, you can't screw it up.. yet :) (you did get the right syntax, regardless 👍 ) |
steveklabnik
commented
Sep 24, 2015
@bors: r+ rollup |
bors
commented
Sep 24, 2015
📌 Commit 09d4dee has been approved by |
critiqjo
commented
Sep 24, 2015
Oh! I misunderstood this:
So r=me simply meant reply/ping me (since there's no notification for commit changes), huh! |
steveklabnik
commented
Sep 24, 2015
via email
It's a signal to anyone else who _does_ have commit to do exactly what you
did, signing off for me. |
r? @steveklabnik