Run rustfmt on liballoc

[nrc]

No description provided.

[rust-highfive]

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

[nrc]

r? @brson

[steveklabnik]

since this is a style PR, I wonder: is it good style to use ; here? I probably would. I know it's not in the original source, so it's not rustfmt doing it.

[nrc]

Agree that we should - https://github.com/nrc/rustfmt/issues/353

[alexcrichton]

I personally prefer to leave off ; whenever it's a terminating statement that can't have anything following it anyway (e.g. break, return, continue) but that may be just my style

[nrc]

The bits Steve and I identified as sub-optimal are all bits which will be changed if we re-run with an improved rustfmt, so I don't think they should block landing this PR.

[Gankra]

Why is this one turned into one-line, but the previous unsafe block has the precise opposite?

[nrc]

We allow one-line unsafe blocks if there is a single expression, the previous one is a single statement. This is obviously an imperfect heuristic, foiled here because there is no semi-colon, even though we don't use the value. We don't have type info in rustfmt (for now), so can't insert the semicolon. I'll fix this instance manually.

[nrc]

@gankro better?

[Gankra]

I'm pretty bumbed out about losing all these sweet one-liners (especially the ternaries and trait impls)...

But the most egregious affronts to the unsafe gods have been removed, for sure.

[brson]

r=me when you are satisfied comments addressed

[nrc]

I think all the comments (except Gankro's which I don't think can be easily addressed) are about possible improvements rather than things that need to be done now.

@bors: r=brson

[bors]

📌 Commit 459f772 has been approved by brson

[bors]

⌛ Testing commit 459f772 with merge 0683d36...

[bors]

💔 Test failed - auto-linux-32-opt

[alexcrichton]

@bors: retry

On Thu, Sep 24, 2015 at 4:32 PM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-linux-32-opt
http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/6560

—
Reply to this email directly or view it on GitHub
#28610 (comment).

[bors]

⌛ Testing commit 459f772 with merge e7a7388...