Uh oh!
There was an error while loading. Please reload this page.
Check attribute usage - #28650
Merged
Merged
Conversation
rust-highfive
commented
Sep 25, 2015
Contributor
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
sanxiynforce-pushed
the
attr-usage
branch
2 times, most recently
from
September 25, 2015 09:50
ab80e64 to
fb22683Comparealexcrichton
commented
Sep 25, 2015
Member
r? @nrc |
alexcrichton
commented
Sep 25, 2015
Member
Starting a crater build to evaluate the impact |
alexcrichton
commented
Sep 25, 2015
Member
Looks like there's only one regression, so should be easy to send a PR for! |
nagisa
commented
Sep 25, 2015
Member
I’d replace error message wording from “should” to “may only” or “may”. Otherwise always 👍 for such correctness PRs. |
Member
There was a problem hiding this comment.
nit:
let words = match attr.meta_item_list() {
Some(words) => words,
None => {
return;
}
};
nrc
commented
Sep 27, 2015
Member
r=me with the style nit fixed |
sanxiynforce-pushed
the
attr-usage
branch
2 times, most recently
from
September 28, 2015 04:54
c04e6d9 to
c5a7d17Comparesanxiyn
commented
Sep 28, 2015
ContributorAuthor
Done. |
nrc
commented
Sep 28, 2015
Member
@bors: r+ |
bors
commented
Sep 28, 2015
Collaborator
📌 Commit c5a7d17 has been approved by |
bors
commented
Sep 28, 2015
Collaborator
⌛ Testing commit c5a7d17 with merge 186df85... |
bors
commented
Sep 28, 2015
Collaborator
💔 Test failed - auto-mac-32-opt |
sanxiyn
commented
Oct 2, 2015
ContributorAuthor
@bors r=nrc |
bors
commented
Oct 2, 2015
Collaborator
📌 Commit 61f5b2b has been approved by |
bors
commented
Oct 2, 2015
Collaborator
bors
commented
Oct 2, 2015
Collaborator
Manishearth
commented
Nov 7, 2015
Member
IMO we should have made this a warning for one release cycle, but I guess this is fine too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is technically a [breaking-change].
Fix#2809.
Fix#22746.