Uh oh!
There was an error while loading. Please reload this page.
Fixes to librustdoc javascript (mostly search) - #28736
Merged
Merged
Conversation
rust-highfive
commented
Sep 29, 2015
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
nagisa
commented
Sep 29, 2015
MemberAuthor
This is very likely to conflict with some future version of #28725. Waiting on the referenced PR to merge; do not review before. |
bors
commented
Oct 2, 2015
Collaborator
☔ The latest upstream changes (presumably #28795) made this pull request unmergeable. Please resolve the merge conflicts. |
Previously only keyup event was looked at, which meant that pasting, cutting and otherwise changing the input without typing would not catch any updates to the search query.
nagisa
commented
Oct 2, 2015
MemberAuthor
Ready for merge. |
alexcrichton
commented
Oct 2, 2015
Member
steveklabnik
commented
Oct 3, 2015
Contributor
@bors: r+ rollup |
bors
commented
Oct 3, 2015
Collaborator
📌 Commit f38bc2c has been approved by |
steveklabnik
commented
Oct 3, 2015
Contributor
lol whoops i added the plus out of habit |
steveklabnik
commented
Oct 3, 2015
Contributor
steveklabnik added a commit
to steveklabnik/rust
that referenced
this pull request
Oct 3, 2015
steveklabnik added a commit
to steveklabnik/rust
that referenced
this pull request
Oct 3, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.