Added info about Sublime Text's Rust syntax package. by mason-stewart · Pull Request #2881 · rust-lang/rust

mason-stewart · 2012-07-12T19:49:37Z

No description provided.

catamorphism · 2012-07-12T19:50:38Z

Thanks for the prompt re-request! I'll merge it once the tree is open again.

mason-stewart · 2012-07-12T19:51:23Z

Awesome, sounds great. Thanks!

z0w0 · 2012-07-13T03:38:05Z

If the package is going to be mentioned in the tutorial, I think it's a good idea to have the package actually working. The package was last changed 5 months ago and breaks a lot because of syntax changes.

mason-stewart · 2012-07-13T12:21:12Z

Hmmm, I saw that the last commit was some months ago, but I didn't realize that it was broken. Shall we close this PR until the package has addressed changes to the syntax?

catamorphism · 2012-07-13T18:22:52Z

Okay, closing. Feel free to submit a new pull request once the package is up to date. Thanks!

Don't lint `cast_ptr_alignment` when used for unaligned reads and writes fixesrust-lang#2881 Ideally this would trace the usage of the value rather than only looking at the parent expression, but that would require dataflow analysis. e.g. ```rust let x = ptr as *const u16; c.read_unaligned(x); ``` Arch specific intrinsic functions need to be checked for ones which could take an unaligned pointer. This can be another PR. changelog: Don't lint `cast_ptr_alignment` when used for unaligned reads and writes

Treat thread-local statics on main thread as static roots for leakage analysis Miri currently treats allocations as leaked if they're only referenced in thread-local statics. For threads other than the main thread, this is correct, since the thread can terminate before the program does, but references in the main thread's locals should be treated as living for the duration of the program since the thread lives for the duration of the program. This PR adds thread-local statics and TLS keys as "static roots" for leakage analysis, but does not yet bless the example program from rust-lang#2881. See rust-lang/miri#2881 (comment)Closesrust-lang#2881

add a pause to improve readability

mason-stewart · 2012-07-12T19:49:37Z

No description provided.

catamorphism · 2012-07-12T19:50:38Z

Thanks for the prompt re-request! I'll merge it once the tree is open again.

mason-stewart · 2012-07-12T19:51:23Z

Awesome, sounds great. Thanks!

z0w0 · 2012-07-13T03:38:05Z

If the package is going to be mentioned in the tutorial, I think it's a good idea to have the package actually working. The package was last changed 5 months ago and breaks a lot because of syntax changes.

mason-stewart · 2012-07-13T12:21:12Z

Hmmm, I saw that the last commit was some months ago, but I didn't realize that it was broken. Shall we close this PR until the package has addressed changes to the syntax?

catamorphism · 2012-07-13T18:22:52Z

Okay, closing. Feel free to submit a new pull request once the package is up to date. Thanks!

Don't lint `cast_ptr_alignment` when used for unaligned reads and writes fixesrust-lang#2881 Ideally this would trace the usage of the value rather than only looking at the parent expression, but that would require dataflow analysis. e.g. ```rust let x = ptr as *const u16; c.read_unaligned(x); ``` Arch specific intrinsic functions need to be checked for ones which could take an unaligned pointer. This can be another PR. changelog: Don't lint `cast_ptr_alignment` when used for unaligned reads and writes

Treat thread-local statics on main thread as static roots for leakage analysis Miri currently treats allocations as leaked if they're only referenced in thread-local statics. For threads other than the main thread, this is correct, since the thread can terminate before the program does, but references in the main thread's locals should be treated as living for the duration of the program since the thread lives for the duration of the program. This PR adds thread-local statics and TLS keys as "static roots" for leakage analysis, but does not yet bless the example program from rust-lang#2881. See rust-lang/miri#2881 (comment)Closesrust-lang#2881

add a pause to improve readability

mason-stewart · 2012-07-12T19:49:37Z

No description provided.

catamorphism · 2012-07-12T19:50:38Z

Thanks for the prompt re-request! I'll merge it once the tree is open again.

mason-stewart · 2012-07-12T19:51:23Z

Awesome, sounds great. Thanks!

z0w0 · 2012-07-13T03:38:05Z

If the package is going to be mentioned in the tutorial, I think it's a good idea to have the package actually working. The package was last changed 5 months ago and breaks a lot because of syntax changes.

mason-stewart · 2012-07-13T12:21:12Z

Hmmm, I saw that the last commit was some months ago, but I didn't realize that it was broken. Shall we close this PR until the package has addressed changes to the syntax?

catamorphism · 2012-07-13T18:22:52Z

Okay, closing. Feel free to submit a new pull request once the package is up to date. Thanks!

Don't lint `cast_ptr_alignment` when used for unaligned reads and writes fixesrust-lang#2881 Ideally this would trace the usage of the value rather than only looking at the parent expression, but that would require dataflow analysis. e.g. ```rust let x = ptr as *const u16; c.read_unaligned(x); ``` Arch specific intrinsic functions need to be checked for ones which could take an unaligned pointer. This can be another PR. changelog: Don't lint `cast_ptr_alignment` when used for unaligned reads and writes

Treat thread-local statics on main thread as static roots for leakage analysis Miri currently treats allocations as leaked if they're only referenced in thread-local statics. For threads other than the main thread, this is correct, since the thread can terminate before the program does, but references in the main thread's locals should be treated as living for the duration of the program since the thread lives for the duration of the program. This PR adds thread-local statics and TLS keys as "static roots" for leakage analysis, but does not yet bless the example program from rust-lang#2881. See rust-lang/miri#2881 (comment)Closesrust-lang#2881

add a pause to improve readability

mason-stewart · 2012-07-12T19:49:37Z

No description provided.

catamorphism · 2012-07-12T19:50:38Z

Thanks for the prompt re-request! I'll merge it once the tree is open again.

mason-stewart · 2012-07-12T19:51:23Z

Awesome, sounds great. Thanks!

z0w0 · 2012-07-13T03:38:05Z

If the package is going to be mentioned in the tutorial, I think it's a good idea to have the package actually working. The package was last changed 5 months ago and breaks a lot because of syntax changes.

mason-stewart · 2012-07-13T12:21:12Z

Hmmm, I saw that the last commit was some months ago, but I didn't realize that it was broken. Shall we close this PR until the package has addressed changes to the syntax?

catamorphism · 2012-07-13T18:22:52Z

Okay, closing. Feel free to submit a new pull request once the package is up to date. Thanks!

Don't lint `cast_ptr_alignment` when used for unaligned reads and writes fixesrust-lang#2881 Ideally this would trace the usage of the value rather than only looking at the parent expression, but that would require dataflow analysis. e.g. ```rust let x = ptr as *const u16; c.read_unaligned(x); ``` Arch specific intrinsic functions need to be checked for ones which could take an unaligned pointer. This can be another PR. changelog: Don't lint `cast_ptr_alignment` when used for unaligned reads and writes

Treat thread-local statics on main thread as static roots for leakage analysis Miri currently treats allocations as leaked if they're only referenced in thread-local statics. For threads other than the main thread, this is correct, since the thread can terminate before the program does, but references in the main thread's locals should be treated as living for the duration of the program since the thread lives for the duration of the program. This PR adds thread-local statics and TLS keys as "static roots" for leakage analysis, but does not yet bless the example program from rust-lang#2881. See rust-lang/miri#2881 (comment)Closesrust-lang#2881

add a pause to improve readability

mason-stewart · 2012-07-12T19:49:37Z

No description provided.

catamorphism · 2012-07-12T19:50:38Z

Thanks for the prompt re-request! I'll merge it once the tree is open again.

mason-stewart · 2012-07-12T19:51:23Z

Awesome, sounds great. Thanks!

z0w0 · 2012-07-13T03:38:05Z

If the package is going to be mentioned in the tutorial, I think it's a good idea to have the package actually working. The package was last changed 5 months ago and breaks a lot because of syntax changes.

mason-stewart · 2012-07-13T12:21:12Z

Hmmm, I saw that the last commit was some months ago, but I didn't realize that it was broken. Shall we close this PR until the package has addressed changes to the syntax?

catamorphism · 2012-07-13T18:22:52Z

Okay, closing. Feel free to submit a new pull request once the package is up to date. Thanks!

Don't lint `cast_ptr_alignment` when used for unaligned reads and writes fixesrust-lang#2881 Ideally this would trace the usage of the value rather than only looking at the parent expression, but that would require dataflow analysis. e.g. ```rust let x = ptr as *const u16; c.read_unaligned(x); ``` Arch specific intrinsic functions need to be checked for ones which could take an unaligned pointer. This can be another PR. changelog: Don't lint `cast_ptr_alignment` when used for unaligned reads and writes

Treat thread-local statics on main thread as static roots for leakage analysis Miri currently treats allocations as leaked if they're only referenced in thread-local statics. For threads other than the main thread, this is correct, since the thread can terminate before the program does, but references in the main thread's locals should be treated as living for the duration of the program since the thread lives for the duration of the program. This PR adds thread-local statics and TLS keys as "static roots" for leakage analysis, but does not yet bless the example program from rust-lang#2881. See rust-lang/miri#2881 (comment)Closesrust-lang#2881

add a pause to improve readability

mason-stewart · 2012-07-12T19:49:37Z

No description provided.

catamorphism · 2012-07-12T19:50:38Z

Thanks for the prompt re-request! I'll merge it once the tree is open again.

mason-stewart · 2012-07-12T19:51:23Z

Awesome, sounds great. Thanks!

z0w0 · 2012-07-13T03:38:05Z

If the package is going to be mentioned in the tutorial, I think it's a good idea to have the package actually working. The package was last changed 5 months ago and breaks a lot because of syntax changes.

mason-stewart · 2012-07-13T12:21:12Z

Hmmm, I saw that the last commit was some months ago, but I didn't realize that it was broken. Shall we close this PR until the package has addressed changes to the syntax?

catamorphism · 2012-07-13T18:22:52Z

Okay, closing. Feel free to submit a new pull request once the package is up to date. Thanks!

Don't lint `cast_ptr_alignment` when used for unaligned reads and writes fixesrust-lang#2881 Ideally this would trace the usage of the value rather than only looking at the parent expression, but that would require dataflow analysis. e.g. ```rust let x = ptr as *const u16; c.read_unaligned(x); ``` Arch specific intrinsic functions need to be checked for ones which could take an unaligned pointer. This can be another PR. changelog: Don't lint `cast_ptr_alignment` when used for unaligned reads and writes

Treat thread-local statics on main thread as static roots for leakage analysis Miri currently treats allocations as leaked if they're only referenced in thread-local statics. For threads other than the main thread, this is correct, since the thread can terminate before the program does, but references in the main thread's locals should be treated as living for the duration of the program since the thread lives for the duration of the program. This PR adds thread-local statics and TLS keys as "static roots" for leakage analysis, but does not yet bless the example program from rust-lang#2881. See rust-lang/miri#2881 (comment)Closesrust-lang#2881

add a pause to improve readability

mason-stewart · 2012-07-12T19:49:37Z

No description provided.

catamorphism · 2012-07-12T19:50:38Z

Thanks for the prompt re-request! I'll merge it once the tree is open again.

mason-stewart · 2012-07-12T19:51:23Z

Awesome, sounds great. Thanks!

z0w0 · 2012-07-13T03:38:05Z

If the package is going to be mentioned in the tutorial, I think it's a good idea to have the package actually working. The package was last changed 5 months ago and breaks a lot because of syntax changes.

mason-stewart · 2012-07-13T12:21:12Z

Hmmm, I saw that the last commit was some months ago, but I didn't realize that it was broken. Shall we close this PR until the package has addressed changes to the syntax?

catamorphism · 2012-07-13T18:22:52Z

Okay, closing. Feel free to submit a new pull request once the package is up to date. Thanks!

Don't lint `cast_ptr_alignment` when used for unaligned reads and writes fixesrust-lang#2881 Ideally this would trace the usage of the value rather than only looking at the parent expression, but that would require dataflow analysis. e.g. ```rust let x = ptr as *const u16; c.read_unaligned(x); ``` Arch specific intrinsic functions need to be checked for ones which could take an unaligned pointer. This can be another PR. changelog: Don't lint `cast_ptr_alignment` when used for unaligned reads and writes

Treat thread-local statics on main thread as static roots for leakage analysis Miri currently treats allocations as leaked if they're only referenced in thread-local statics. For threads other than the main thread, this is correct, since the thread can terminate before the program does, but references in the main thread's locals should be treated as living for the duration of the program since the thread lives for the duration of the program. This PR adds thread-local statics and TLS keys as "static roots" for leakage analysis, but does not yet bless the example program from rust-lang#2881. See rust-lang/miri#2881 (comment)Closesrust-lang#2881

add a pause to improve readability

mason-stewart · 2012-07-12T19:49:37Z

No description provided.

catamorphism · 2012-07-12T19:50:38Z

Thanks for the prompt re-request! I'll merge it once the tree is open again.

mason-stewart · 2012-07-12T19:51:23Z

Awesome, sounds great. Thanks!

z0w0 · 2012-07-13T03:38:05Z

If the package is going to be mentioned in the tutorial, I think it's a good idea to have the package actually working. The package was last changed 5 months ago and breaks a lot because of syntax changes.

mason-stewart · 2012-07-13T12:21:12Z

Hmmm, I saw that the last commit was some months ago, but I didn't realize that it was broken. Shall we close this PR until the package has addressed changes to the syntax?

catamorphism · 2012-07-13T18:22:52Z

Okay, closing. Feel free to submit a new pull request once the package is up to date. Thanks!

Don't lint `cast_ptr_alignment` when used for unaligned reads and writes fixesrust-lang#2881 Ideally this would trace the usage of the value rather than only looking at the parent expression, but that would require dataflow analysis. e.g. ```rust let x = ptr as *const u16; c.read_unaligned(x); ``` Arch specific intrinsic functions need to be checked for ones which could take an unaligned pointer. This can be another PR. changelog: Don't lint `cast_ptr_alignment` when used for unaligned reads and writes

Treat thread-local statics on main thread as static roots for leakage analysis Miri currently treats allocations as leaked if they're only referenced in thread-local statics. For threads other than the main thread, this is correct, since the thread can terminate before the program does, but references in the main thread's locals should be treated as living for the duration of the program since the thread lives for the duration of the program. This PR adds thread-local statics and TLS keys as "static roots" for leakage analysis, but does not yet bless the example program from rust-lang#2881. See rust-lang/miri#2881 (comment)Closesrust-lang#2881

add a pause to improve readability

Added info about Sublime Text's Rust syntax package.
c2ce549

ghost assigned catamorphism Jul 12, 2012

catamorphism closed this Jul 13, 2012

mason-stewart unassigned catamorphism Jun 16, 2014