Uh oh!
There was an error while loading. Please reload this page.
book: Add documentation on custom allocators - #28869
Merged
Merged
Conversation
rust-highfive
commented
Oct 6, 2015
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
There was a problem hiding this comment.
If this is declared to be a dylib, why is main present?
Contributor
There was a problem hiding this comment.
IIRC Rustdoc has issues here, basically
MemberAuthor
There was a problem hiding this comment.
Ah yeah this is just needed to appears rustdoc --test, the dylib above if for readers and the fn main is needed because rustdoc overrides the crate_type in the source with a manual specification.
steveklabnik
commented
Oct 6, 2015
Contributor
🤘 ❤️ |
steveklabnik
commented
Oct 6, 2015
Contributor
Looks great to me! Just some nits. |
alexcrichtonforce-pushed
the
allocator-dox
branch
from
October 6, 2015 22:03
105cb33 to
9a38747Comparealexcrichton
commented
Oct 6, 2015
MemberAuthor
re-r? @steveklabnik |
steveklabnik
commented
Oct 6, 2015
Contributor
@bors: r+ rollup |
bors
commented
Oct 6, 2015
Collaborator
📌 Commit 9a38747 has been approved by |
Manishearth added a commit
to Manishearth/rust
that referenced
this pull request
Oct 7, 2015
…klabnik This adds a chapter to the nightly section of the book on leveraging and implementing the `#![allocator]` attribute to write custom allocators as well as explaining the current situation with allocators.
steveklabnik added a commit
to steveklabnik/rust
that referenced
this pull request
Oct 7, 2015
…klabnik This adds a chapter to the nightly section of the book on leveraging and implementing the `#![allocator]` attribute to write custom allocators as well as explaining the current situation with allocators.
steveklabnik
commented
Oct 7, 2015
Contributor
@bors: r- |
steveklabnik
commented
Oct 7, 2015
Contributor
alexcrichtonforce-pushed
the
allocator-dox
branch
from
October 8, 2015 04:24
9a38747 to
994a577Comparealexcrichton
commented
Oct 8, 2015
MemberAuthor
steveklabnik added a commit
to steveklabnik/rust
that referenced
this pull request
Oct 8, 2015
…klabnik This adds a chapter to the nightly section of the book on leveraging and implementing the `#![allocator]` attribute to write custom allocators as well as explaining the current situation with allocators.
steveklabnik
commented
Oct 8, 2015
Contributor
Still looks like it's failing http://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt/builds/1646/steps/test/logs/stdio |
steveklabnik
commented
Oct 8, 2015
Contributor
@bors: r- |
This adds a chapter to the nightly section of the book on leveraging and implementing the `#![allocator]` attribute to write custom allocators as well as explaining the current situation with allocators.
alexcrichtonforce-pushed
the
allocator-dox
branch
from
October 8, 2015 19:49
994a577 to
abe7874Comparealexcrichton
commented
Oct 8, 2015
MemberAuthor
bors
commented
Oct 9, 2015
Collaborator
bors added a commit
that referenced
this pull request
Oct 9, 2015
This adds a chapter to the nightly section of the book on leveraging and implementing the `#![allocator]` attribute to write custom allocators as well as explaining the current situation with allocators.
bors
commented
Oct 9, 2015
Collaborator
steveklabnik
commented
Oct 9, 2015
Contributor
🎊 On Fri, Oct 9, 2015 at 4:53 AM, bors notifications@github.com wrote:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a chapter to the nightly section of the book on leveraging and
implementing the
#![allocator]attribute to write custom allocators as well asexplaining the current situation with allocators.