Skip to content

Add E0510, E0511 and E0512 error explanations - #28909

Merged
bors merged 3 commits into
rust-lang:masterfrom
GuillaumeGomez:patch-3
Oct 14, 2015
Merged

Add E0510, E0511 and E0512 error explanations#28909
bors merged 3 commits into
rust-lang:masterfrom
GuillaumeGomez:patch-3

Conversation

@GuillaumeGomez

@GuillaumeGomezGuillaumeGomez commented Oct 8, 2015

Copy link
Copy Markdown
Member

@GuillaumeGomezGuillaumeGomez changed the title Add E0512 error explanationAdd E0510 and E0512 error explanationsOct 8, 2015
@GuillaumeGomez

GuillaumeGomez commented Oct 8, 2015

Copy link
Copy Markdown
MemberAuthor

Thanks to @oli-obk for his great help on E0510 !

@bors

bors commented Oct 8, 2015

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #28897) made this pull request unmergeable. Please resolve the merge conflicts.

@GuillaumeGomez

GuillaumeGomez commented Oct 8, 2015

Copy link
Copy Markdown
MemberAuthor

Updated ! Review needed.

@GuillaumeGomez

GuillaumeGomez commented Oct 9, 2015

Copy link
Copy Markdown
MemberAuthor

r? @steveklabnik
cc @gankro

@GuillaumeGomezGuillaumeGomez changed the title Add E0510 and E0512 error explanationsAdd E0510, E0511 and E0512 error explanationsOct 9, 2015
nagisa
nagisa reviewed Oct 10, 2015
View reviewed changes
Comment threadsrc/librustc_trans/diagnostics.rs Outdated

@nagisanagisaOct 10, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“An intrinsic was monomorphized invalidly.” or “Invalid monomorphization of an intrinsic was used” maybe? You can’t “use” monomorphization “on” something.

@GuillaumeGomezGuillaumeGomez mentioned this pull request Oct 11, 2015
Merged
pnkfelix
pnkfelix reviewed Oct 13, 2015
View reviewed changes
Comment threadsrc/librustc_trans/diagnostics.rs Outdated

@pnkfelixpnkfelixOct 13, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"value is big enough [...] to not fit into ..." is awkward phrasing at best.

I would instead say "value is too big [...] to fit into ..."

@GuillaumeGomezGuillaumeGomezOct 13, 2015

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if " may be stored in a return register(s)" was correct too. Is it ?

@pnkfelix

pnkfelix commented Oct 13, 2015

Copy link
Copy Markdown
Contributor

(r=me after applying adjustments suggested above.)

apasel422
apasel422 reviewed Oct 13, 2015
View reviewed changes
Comment threadsrc/librustc_trans/diagnostics.rs Outdated

@apasel422apasel422Oct 13, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/to not fit/to fit/

@GuillaumeGomez

GuillaumeGomez commented Oct 13, 2015

Copy link
Copy Markdown
MemberAuthor

Updated !

@pnkfelix

pnkfelix commented Oct 14, 2015

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Oct 14, 2015

Copy link
Copy Markdown
Collaborator

📌 Commit 4618aad has been approved by pnkfelix

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@steveklabniksteveklabnik

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@GuillaumeGomez@bors@pnkfelix@nagisa@apasel422@steveklabnik@Manishearth