Uh oh!
There was an error while loading. Please reload this page.
rusftmt libfmt_macros - #29024
Conversation
rust-highfive
commented
Oct 13, 2015
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
nrc
commented
Oct 13, 2015
Thanks for the PR! Could you remove the fixup, then r+. |
This reverts commit 5b8335e.
mseri
commented
Oct 13, 2015
@nrc reverted. Thanks for the review |
nrc
commented
Oct 13, 2015
Thanks! @bors: r+ |
bors
commented
Oct 13, 2015
📌 Commit 1454b42 has been approved by |
r? @nrc