Uh oh!
There was an error while loading. Please reload this page.
Update jemalloc to 4.0.3 - #29196
Conversation
rust-highfive
commented
Oct 21, 2015
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
fbernier
commented
Oct 21, 2015
So, I am not sure it's going to build finally. it looks like jemalloc 4.0.3 doesn't ship with a configure script and it has to be generated with |
fbernier
commented
Oct 21, 2015
and rust-lang/jemalloc would need to be updated. I guess I should not be doing this as it looks like this whole job should be made by someone from the core team. Sorry for the noise. |
alexcrichton
commented
Oct 21, 2015
@fbernier ah I'm totally fine trying out the update again! You'll want to open a PR against |
fbernier
commented
Oct 21, 2015
Great! Will do that soon. Thanks! |
Updating to 4.0.0 had already been attempted here, but for some reasons the tests failed. I just tried with the latest jemalloc release and they seemed to work (if I am doing this right).